Comment 5 for bug 1535549

Reviewed: https://review.openstack.org/341427
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=17005132d1b17d608077090573c50af591afe670
Submitter: Jenkins
Branch: master

commit 17005132d1b17d608077090573c50af591afe670
Author: Anh Tran <email address hidden>
Date: Mon Aug 22 17:28:29 2016 +0700

    Rollback port after failed to add it to router

    After failed to add port to a router, we cannot re-use and/or delete
    this port.

    With concurrent requests occuring, neutron will accept one request
    and the other will be rejected with an 'overlapped CIDR' message.
    Patch [1] fixed the race condition, but neutron raises
    'Port already has an attached device' instead of
    'overlapped CIDR', because neutron didn't cleanup the port when
    the request was retried.
    [1] https://review.openstack.org/#/c/303966/

    This patch is needed to fix the bug completely. We will catch any
    exception when adding an interface by port to a router. After that,
    we rollback this port to its original state.

    Change-Id: Ib68aee164a3062648fc882012d57b5e381f52196
    Closes-Bug: #1535549