commit 71fa1820008b998809890c52b366c8acf9cb72a4
Author: Terry Wilson <email address hidden>
Date: Wed Jan 6 01:19:31 2016 -0600
Make sure datapath_type is updated on bridges changed
When changing datapath_type in the config, physical and tunnel bridges
do not have their datapath_type updated. Calling create() on already
created bridges should be safe as it passes '--may-exist' when adding
the bridge, which will do nothing if the bridge already exists, but
the second part of the transaction will still update things like
datapath_type.
It should be noted that ancillary bridges (like br-ex) are not
modified by this patch as datapath_type was never applied to them to
begin with.
Incidentally, the native and vsctl versions behaved slightly
differently when handling datapath_type: vsctl builds the multi-cmd
transaction with add-br ... -- set ..., so that the second cmd would
actually complete. The native just bailed if may_exist and the bridge
existed. This is fixed as part of this patch.
Reviewed: https:/ /review. openstack. org/265374 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=71fa1820008 b998809890c52b3 66c8acf9cb72a4
Committed: https:/
Submitter: Jenkins
Branch: master
commit 71fa1820008b998 809890c52b366c8 acf9cb72a4
Author: Terry Wilson <email address hidden>
Date: Wed Jan 6 01:19:31 2016 -0600
Make sure datapath_type is updated on bridges changed
When changing datapath_type in the config, physical and tunnel bridges
do not have their datapath_type updated. Calling create() on already
created bridges should be safe as it passes '--may-exist' when adding
the bridge, which will do nothing if the bridge already exists, but
the second part of the transaction will still update things like
datapath_type.
It should be noted that ancillary bridges (like br-ex) are not
modified by this patch as datapath_type was never applied to them to
begin with.
Incidentally, the native and vsctl versions behaved slightly
differently when handling datapath_type: vsctl builds the multi-cmd
transaction with add-br ... -- set ..., so that the second cmd would
actually complete. The native just bailed if may_exist and the bridge
existed. This is fixed as part of this patch.
Change-Id: Ib8bc817c7bc724 d80193d0ca7af48 0a7ea103f77
Closes-Bug: 1532273