Comment 8 for bug 1519171

Revision history for this message
Ann Taraday (akamyshnikova) wrote :

The test is running on MySQL and PostgreSQL backends. On both of them difference of Integer and BigInteger is skipped. In test from oslo.db comapare_type is provided [1], and in fact difference in other types is checked. If I set String in model and Integer in migration test will fail on that. The example of code is shown here [2]. When I debug code I see that compare_type [3] gets meta_type.impl as Integer and insp_type as BIGINT and this difference was not detected. In fact when I change Integer for BigInteger in some places it was not detected either.

[1] - https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/test_migrations.py#L592
[2] - https://review.openstack.org/#/c/222079/15/neutron/db/migration/alembic_migrations/versions/mitaka/expand/32e5974ada25_add_neutron_resources_table.py
[3] - https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/test_migrations.py#L418

I will sum up all of this and report in https://bitbucket.org/zzzeek/alembic.

Thanks!