Firewall-Update command help content does not display "admin_state_up" argument

[ranjitray]

Get the help contents of the firewall-update command

stack@stevens-creek:~/firewall$ neutron help firewall-update
usage: neutron firewall-update [-h] [--request-format {json,xml}]
                               [--policy POLICY]
                               [--router ROUTER | --no-routers]
                               FIREWALL

Update a given firewall.

positional arguments:
  FIREWALL ID or name of firewall to update.

optional arguments:
  -h, --help show this help message and exit
  --request-format {json,xml}
                        The XML or JSON request format.
  --policy POLICY Firewall policy name or ID.
  --router ROUTER Firewall associated router names or IDs (requires
                        FWaaS router insertion extension, this option can be
                        repeated)
  --no-routers Associate no routers with the firewall (requires FWaaS
                        router insertion extension)
stack@stevens-creek:~/firewall$

Issue :
--admin_state_up argument does not display in the contents

Expected:

Help contents should have --admin_state_up argumment since we are able to make firewall UP and DOWN by updating the --admin_state_up toTrue/False

[Ihar Hrachyshka (ihar-hrachyshka)]

Note that by doing the change, we should not break existing behaviour (where we can pass --admin_state_up=True or --admin_state_up True, and both will work).

[James Arendt (james-arendt-7)]

Local tester noticed same issue - will attempt fix.

[James Arendt (james-arendt-7)]

The CLI help is in the python-neutronclient, not on the neutron server side, so moved bug there. Fix is in review https://review.openstack.org/#/c/234916/

[Reedip (reedip-banerjee-deactivatedaccount)]

Hi All,
I have already reported a similar bug on https://bugs.launchpad.net/python-neutronclient/+bug/1504411 and working on it.
So , I think this might be a duplicate

[Reedip (reedip-banerjee-deactivatedaccount)]

Fix is in review : https://review.openstack.org/#/c/234518/ and it is dependent on the changes of https://review.openstack.org/#/c/190968/26

[Reedip (reedip-banerjee-deactivatedaccount)]

Also, as per the response from Akihiro Motoki:
¨There are a lot of similar discussions. I would like to make a consensus first.
I created etherpad page: https://etherpad.openstack.org/p/neutronclient-adding-update-option . Feel free to comment (with your name).¨

[OpenStack Infra (hudson-openstack)]

Change abandoned by James Arendt (<email address hidden>) on branch: master
Review: https://review.openstack.org/234916
Reason: Decided to abandon this change as other somewhat similar changes in the works.

[Reedip (reedip-banerjee-deactivatedaccount)]

Being tracked in https://bugs.launchpad.net/python-neutronclient/+bug/1504411

[Reedip (reedip-banerjee-deactivatedaccount)]

Its clone, https://bugs.launchpad.net/python-neutronclient/+bug/1504411 has successfully merged and released