Neutron Firewall CLIs do not show all updatable options in help

Bug #1504411 reported by Reedip
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Low
Unassigned

Bug Description

Firewall-policy-update and firewall-update do not show all the options which can be updated by the NeutronClient CLI.
Actual output:
Firewall Policy Update has the following arguments:
usage: neutron firewall-policy-update [-h] [--request-format {json,xml}]
                                      [--firewall-rules FIREWALL_RULES]
                                      FIREWALL_POLICY

Expected output:
It is missing :
- shared
- audited
- description
- name

Actual output:
Firewall Update has the following arguments:
usage: neutron firewall-update [-h] [--request-format {json,xml}]
                               [--policy POLICY]
                               [--router ROUTER | --no-routers]
                               FIREWALL

Expected output:
It is missing:
- admin_state
- description
- name

Pre-conditions: Create a Firewall Rule. Create a Firewall Policy and a Firewall. Then try to update the Policy and Firewall.

affects: neutron → python-neutronclient
Changed in python-neutronclient:
assignee: nobody → Reedip (reedip-banerjee)
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Again, note that old boolean syntax must work after the fix: --shared=True or --shared True

tags: added: fwaas low-hanging-fruit usability
summary: Firewall-policy-update and firewall-update do not show all updatable
- options in ´help´
+ options in help
Changed in python-neutronclient:
importance: Undecided → Low
Revision history for this message
Reedip (reedip-banerjee-deactivatedaccount) wrote : Re: Firewall-policy-update and firewall-update do not show all updatable options in help

Hi Ihar,
Ok, will make sure of that

summary: - Firewall-policy-update and firewall-update do not show all updatable
- options in help
+ Neutron CLIs do not show all updatable options in help
summary: - Neutron CLIs do not show all updatable options in help
+ Neutron Firewall CLIs do not show all updatable options in help
description: updated
Changed in python-neutronclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/234518
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=eafefadeefa3e5ea1d0f41a8af85017505a0d1bd
Submitter: Jenkins
Branch: master

commit eafefadeefa3e5ea1d0f41a8af85017505a0d1bd
Author: Reedip Banerjee <email address hidden>
Date: Thu Dec 10 10:22:19 2015 +0530

    Show all updatable options in (fw/fw-policy)-update CLI

    Currently firewall-policy-update and firewall-update CLIs
    do not show all the options which can be updated in its help
    section.

    This patch adds the following updatable options
    # Firewall-Policy:
    - shared
    - audited
    - description
    - name

    # Firewall:
    - admin-state
    - description
    - name

    This patch adds the information to the above FW CLIs.

    Change-Id: I66a80ff68fc369298528cd59923c294ed39f4e80
    Closes-Bug: #1504411

Changed in python-neutronclient:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-neutronclient 4.1.0

This issue was fixed in the openstack/python-neutronclient 4.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.