DNS lookup code in get_ports needs to be optimized

Bug #1497450 reported by Ryan Moats
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Miguel Lavalle

Bug Description

Kilo's get_ports code can be found at http://pastebin.com/PjVG2KFt while Liberty's get_ports code can be found at http://pastebin.com/wpmTx8H7

The difference in the two code paths (the DNS code) leads to an execution time difference shown in http://ibin.co/2G72PkX2eshD

Revision history for this message
Carl Baldwin (carl-baldwin) wrote :

Miguel, let's take some time next week to look at how to optimize the DNS code path in get_port(s). I think we should be able to figure this out.

tags: added: l3-ipam-dhcp
Changed in neutron:
assignee: nobody → Miguel Lavalle (minsel)
Revision history for this message
Kyle Mestery (mestery) wrote :

Leaving this in Liberty for now, as the optimization seems to be worth the wait.

Changed in neutron:
status: New → Confirmed
Revision history for this message
Miguel Lavalle (minsel) wrote :

A tentative approach to fix this bug has been discussed with Carl Baldwin. Plan is to have first patchset for review up in Gerrit by 9/22

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
Miguel Lavalle (minsel) wrote :

Approach is to eliminate the queries to the DB for subnets when handling the DNS assignment for ports

Revision history for this message
Miguel Lavalle (minsel) wrote :

9/21 EOD status : Making good progress. Patchset will be in Gerrit on 9/22

Revision history for this message
Kyle Mestery (mestery) wrote :

Will evaluate the patch EOD 9-22 and decide if it is an RC blocker.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/226535

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Miguel Lavalle (<email address hidden>) on branch: master
Review: https://review.openstack.org/226535

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/226581

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/226581
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2d68a0ed42d3eb3d6187fb5ae78b7b38001dcfdb
Submitter: Jenkins
Branch: master

commit 2d68a0ed42d3eb3d6187fb5ae78b7b38001dcfdb
Author: Miguel Lavalle <email address hidden>
Date: Tue Sep 22 17:22:31 2015 -0500

    Eliminate autoaddress check for DNS integration

    The autoaddress check for DNS integartion is not required anymore. It is
    removed from the DB plugin. This check was being performed to reflect
    incorrect functionality in the DHCP agent as indicated in bug
    https://bugs.launchpad.net/neutron/+bug/1498665

    Change-Id: I4b00618c328567f998765ed9a023c4c50d950b2b
    Closes-Bug: #1497450

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
Ryan Moats (rmoats) wrote :

Confirmed that this fix addresses the performance issue - Thanks!

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.