no dnsmasq name resolution for IPv6 addresses

Bug #1498665 reported by Kevin Benton
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Kevin Benton
Kilo
Fix Released
Undecided
Unassigned

Bug Description

The logic to prevent IPv6 entries from being entered as hosts into the lease DB[1] is preventing the hosts from getting name resolution from dnsmasq.

1. https://github.com/openstack/neutron/blob/7707cfd86f47dfc66411e274f343fe8484f9e250/neutron/agent/linux/dhcp.py#L534-L535

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/226577

Changed in neutron:
status: New → In Progress
tags: added: l3-ipam-dhcp
Changed in neutron:
importance: Undecided → High
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/226577
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1daf945f832716b98b8c2d630cd2e730178a46fa
Submitter: Jenkins
Branch: master

commit 1daf945f832716b98b8c2d630cd2e730178a46fa
Author: Kevin Benton <email address hidden>
Date: Thu Sep 17 09:53:46 2015 -0700

    Remove early yields in _iter_hosts in dhcp agent

    There were early yields in the DHCP agent to handling skipping
    lease setup for certain IPv6 addresses. However, the setup for
    name resolution in _output_addn_hosts_file depends on the same
    function so certain IPv6 addresses weren't getting name resolution.

    This patch adjusts the function to return a flag indicating that
    DHCP isn't required for the port so the callers setting up reservations
    can skip based on that and the name resolution setup can continue
    as normal.

    Change-Id: I81b4669eadaa9119e08c6a5e1d2a7b5959babdcc
    Closes-Bug: #1498665

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
summary: - no dnsmasq name resolution for slaac addresses
+ no dnsmasq name resolution for IPv6 addresses
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/227424

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/kilo)

Reviewed: https://review.openstack.org/227424
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fc1c812fa6f6fab1910f00f23cb4efe45793557a
Submitter: Jenkins
Branch: stable/kilo

commit fc1c812fa6f6fab1910f00f23cb4efe45793557a
Author: Kevin Benton <email address hidden>
Date: Thu Sep 17 09:53:46 2015 -0700

    Remove early yields in _iter_hosts in dhcp agent

    There were early yields in the DHCP agent to handling skipping
    lease setup for certain IPv6 addresses. However, the setup for
    name resolution in _output_addn_hosts_file depends on the same
    function so certain IPv6 addresses weren't getting name resolution.

    This patch adjusts the function to return a flag indicating that
    DHCP isn't required for the port so the callers setting up reservations
    can skip based on that and the name resolution setup can continue
    as normal.

    Conflicts:
     neutron/agent/linux/dhcp.py
     neutron/tests/unit/agent/linux/test_dhcp.py

    Change-Id: I81b4669eadaa9119e08c6a5e1d2a7b5959babdcc
    Closes-Bug: #1498665
    (cherry picked from commit 1daf945f832716b98b8c2d630cd2e730178a46fa)

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.