The code to generate the names of the patch ports
was based on a chunk of the bridge name starting from
the beginning. With the long suffix, this ended up
excluding all of the random characters in the name.
(e.g. br-int374623235 would create an interface br-in-patch-tun).
This meant that if two tests using patch interfaces ran together,
they would have a name collision and one would fail.
This patch updates the patch port name generation to use the
randomized back portion of the name.
Patch 4e77442d5 added a retry decorator to the API layer
to catch DB deadlock errors. However, when they occur, the
retried operation ends up being ineffective because the original
body has been altered, which leads the notification and validation
layers to barf exceptions due to unrecognized/unserializable elements.
This ultimately results to an error reported to the user.
To address this, let's make a deep copy of the request body, before
we pass it down to the lower layers. This allows the decorator to
work on a pristine copy of the body on every attempt. The performance
impact for this should be negligible.
commit 8dd8a7d93564168b98fa2350eedf56acede42b0f
Author: Sean M. Collins <email address hidden>
Date: Tue Jun 30 12:06:07 2015 -0400
Remove bridge cleanup call
Remove the bridge cleanup call to delete bridges, since we are seeing
race conditions where bridges are deleted, then new interfaces are
created and are attempting to plug into the bridge before it is
recreated.
commit 4dc68ea88bf4f07b13253bf9eeedffe22b1f8013
Author: Kevin Benton <email address hidden>
Date: Thu May 28 23:13:19 2015 -0700
Read vif port information in bulk
During startup, the agent was making many calls per port
to read information about the current VLAN, external ID, etc.
This resulted in hundreds of calls just to read information about
a relatively small number of ports.
This patch addresses that by converting a few key functions to
lookup information for all of the ports at once.
Performance improvement on dev laptop for 250 ports from agent
start to port ACTIVE status:
before: 1m21s
after: 1m06s
Reviewed: https:/ /review. openstack. org/197990 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=8a0e11143ca dfc925e6f986fb3 9d73e6879a8fae
Committed: https:/
Submitter: Jenkins
Branch: feature/qos
commit f1771131a85a2fe 633126f35436420 5554ef71d1
Author: Kevin Benton <email address hidden>
Date: Wed Jul 1 13:06:38 2015 -0700
Change the half of the bridge name used for ports
The code to generate the names of the patch ports
was based on a chunk of the bridge name starting from
the beginning. With the long suffix, this ended up
excluding all of the random characters in the name.
(e.g. br-int374623235 would create an interface br-in-patch-tun).
This meant that if two tests using patch interfaces ran together,
they would have a name collision and one would fail.
This patch updates the patch port name generation to use the
randomized back portion of the name.
Change-Id: I172e0b2c0b53e8 c7151bd92f09157 73ea62c0c6a
Closes-Bug: #1470637
commit 49569327c20d8a1 0ba3d426833ff28 d68b1b7a27
Author: armando-migliaccio <email address hidden>
Date: Wed Jul 1 12:00:14 2015 -0700
Fix log traces induced by retry decorator
Patch 4e77442d5 added a retry decorator to the API layer unserializable elements.
to catch DB deadlock errors. However, when they occur, the
retried operation ends up being ineffective because the original
body has been altered, which leads the notification and validation
layers to barf exceptions due to unrecognized/
This ultimately results to an error reported to the user.
To address this, let's make a deep copy of the request body, before
we pass it down to the lower layers. This allows the decorator to
work on a pristine copy of the body on every attempt. The performance
impact for this should be negligible.
Closes-bug: #1470615
Change-Id: I82a2a002612d28 fa8f97b0afbd4f7 ba1e8830377
commit cf8c9e40c872003 6bd0c06bd8370f8 8a472e3e6f
Author: Fawad Khaliq <email address hidden>
Date: Tue Jun 30 02:17:19 2015 -0700
Update PLUMgrid plugin information
README was quite oudated and created confusion
among users.
Updated the information after decomposition.
Change-Id: I78bf8dec20ba2c eb644d4565035d2 9bbf53cb3b5
commit 8dd8a7d93564168 b98fa2350eedf56 acede42b0f
Author: Sean M. Collins <email address hidden>
Date: Tue Jun 30 12:06:07 2015 -0400
Remove bridge cleanup call
Remove the bridge cleanup call to delete bridges, since we are seeing
race conditions where bridges are deleted, then new interfaces are
created and are attempting to plug into the bridge before it is
recreated.
Change-Id: I4ccc96566a5770 384eacbbdc492bf 09a514f5b31
Related-Bug: #1328546
commit 4dc68ea88bf4f07 b13253bf9eeedff e22b1f8013
Author: Kevin Benton <email address hidden>
Date: Thu May 28 23:13:19 2015 -0700
Read vif port information in bulk
During startup, the agent was making many calls per port
to read information about the current VLAN, external ID, etc.
This resulted in hundreds of calls just to read information about
a relatively small number of ports.
This patch addresses that by converting a few key functions to
lookup information for all of the ports at once.
Performance improvement on dev laptop for 250 ports from agent
start to port ACTIVE status:
before: 1m21s
after: 1m06s
Closes-Bug: #1460233 5651dc19819c6ce bdc2048dda7
Change-Id: Ic80c85a07fee3e