Comment 1 for bug 1445052

Reviewed: https://review.openstack.org/168115
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=d7f65a2dbce4d25b1c5d76500a5365da5f9dfffd
Submitter: Jenkins
Branch: master

commit d7f65a2dbce4d25b1c5d76500a5365da5f9dfffd
Author: Paul Michali <email address hidden>
Date: Thu Mar 26 14:52:07 2015 -0400

    VPNaaS: Revise functional test hooks

    This commit does several things to allow functional tests to run, using a
    DevStack configuration, but without stacking.

    First, the gate_hook.sh is modified to specified environment variables
    needed for processing, and will call configure_vpn_for_func_testing.sh.

    The new configure_for_vpn_func_testing.sh script will first call the Neutron
    configure_for_func_testing.sh script (as modified in [1]) to setup DevStack.
    The script then installs the IPSec package, based on the functional job, and
    will create the vpn_agent.ini file, in case it is needed for tests.

    Minor changes are made to the post-test_hook.sh to indicate the location for
    the Neutron and VPN repos.

    Lastly, tox.ini is modified to place the rootwrap related files into the
    virtual environment, copy in the VPN rootwrap filter, set up the rootwrap
    commands, and copy the (customized) rootwrap.conf to /etc/neutron.

    This last step is needed, because the neutron-vpn-netns-wrapper script that
    is (currently) used for StrongSwan, uses /etc/neutron/rootwrap.conf and
    doesn't allow overriding. This copying is a simple approach that will work
    when multiple functional jobs are running, as the same config is used.

    As a future follow-up commit, we could look into modifying the VPN device
    drivers to pass the full path to the rootwrap.conf as a argument to the
    neutron-vpn-netns-wrapper script (--rootwrap_config). The setting could
    be added to the vpnagent.ini config file, available via config, to allow
    this to be customized to something other than /etc/neutron (for production
    use), and the functional tests could override it to point to the right
    virtual environment.

    To configure the environment for local run of the functional test, one
    can do:
        tools/configure_for_vpn_func_testing.sh <devstack-repo> [-i]

    where:
       devstack-repo... Path to devstack repo (/opt/stack/new/devstack
                        when run by gate)
       -i.............. Indicates to install Neutron package dependencies

    For StrongSwan, prefix the command with VENV=dsvm-functional-sswan

    Ref: [1] https://review.openstack.org/#/c/176064/

    Change-Id: I2243b06b3cdbb352dac7bc47d03c830efb87be3c
    Closes-Bug: #1445052
    Depends-On: Ie490e89c1a65e126ad0a57d062076e472762837e