Comment 9 for bug 1413111

Reviewed: https://review.openstack.org/148862
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b117e8ec854dd0a26d04beb7e1effedffec3cb3a
Submitter: Jenkins
Branch: master

commit b117e8ec854dd0a26d04beb7e1effedffec3cb3a
Author: Yalei Wang <email address hidden>
Date: Wed Jan 21 17:48:56 2015 +0800

    Move the assignment of existing_floating_ips before try block

    In function _process_external() in agent/l3/agent.py, the call to
    iptables_manager.defer_apply() may throw an exception, making a
    later call to _update_fip_statuses() use an un-initialized value.
    This will throw its own UnboundLocalError, with the result being
    no iptables rules will be applied.

    Added tests to cover both the defer_apply() code exception
    processing, as well as this new case where we might jump to
    _update_fip_statuses() without having done any work on floating
    IP addresses.

    Change-Id: I0045effc9319772127758be4aacca02ab5c236cd
    Closes-Bug: #1413111