adopt namespace-less oslo imports

Bug #1409733 reported by Ihar Hrachyshka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
Jay Bryant
Glance
Undecided
Liyingjun
OpenStack Compute (nova)
Medium
Davanum Srinivas (DIMS)
OpenStack Dashboard (Horizon)
Undecided
Masco
neutron
Low
Ihar Hrachyshka

Bug Description

Oslo is migrating from oslo.* namespace to separate oslo_* namespaces for each library: https://blueprints.launchpad.net/oslo-incubator/+spec/drop-namespace-packages

We need to adopt to the new paths in neutron. Specifically, for oslo.config, oslo.middleware, oslo.i18n, oslo.serialization, oslo.utils.

Changed in neutron:
assignee: nobody → Ihar Hrachyshka (ihar-hrachyshka)
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/147215

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-vpnaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/147240

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-lbaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/147245

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-fwaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/147248

Kyle Mestery (mestery)
Changed in neutron:
milestone: none → kilo-2
Masco (masco)
Changed in horizon:
assignee: nobody → Masco Kaliyamoorthy (masco)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148184

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148480

Changed in python-neutronclient:
assignee: nobody → Masco Kaliyamoorthy (masco)
status: New → In Progress
Changed in nova:
assignee: nobody → venkata anil (anil-venkata)
Changed in cinder:
assignee: nobody → Numan Siddique (numansiddique)
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :
Changed in nova:
status: New → In Progress
importance: Undecided → Medium
assignee: venkata anil (anil-venkata) → Davanum Srinivas (DIMS) (dims-v)
Revision history for this message
Mike Perez (thingee) wrote :

Jay has already started on this in Cinder. Numan, please coordinate with him in #openstack-cinder, nick is jungleboyj,

Changed in cinder:
assignee: Numan Siddique (numansiddique) → Jay Bryant (jsbryant)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/148184
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=193e66792f8e98ba85d48f6d23234f72af48c53d
Submitter: Jenkins
Branch: master

commit 193e66792f8e98ba85d48f6d23234f72af48c53d
Author: Masco Kaliyamoorthy <email address hidden>
Date: Mon Jan 19 12:19:19 2015 +0530

    adopt namespace-less oslo imports

    oslo.config is now deprecated, so switching
    from oslo.config to right package oslo_config.

    similarly oslo.serialization also deprecated, it
    is also switched to oslo_serialization from
    oslo.serialization.

    Change-Id: I52eff48a17a555750379e4ca6bb024fc71a4efeb
    Closes-Bug: #1409733

Changed in horizon:
status: In Progress → Fix Committed
Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → High
milestone: none → kilo-2
status: New → In Progress
Revision history for this message
Jay Bryant (jsbryant) wrote :

I have been working on this in Cinder and most of the patches are merged:

oslo_config: https://review.openstack.org/147656
oslo_db: https://review.openstack.org/147342
oslo_utils: https://review.openstack.org/148018
hacking check for the changes: https://review.openstack.org/147014

The change for oslo_concurrency was merged a while back.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/149426

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/149426
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=30bb83d64ffebeb7d0cdca170e658f25f3e02c63
Submitter: Jenkins
Branch: master

commit 30bb83d64ffebeb7d0cdca170e658f25f3e02c63
Author: Jay S. Bryant <email address hidden>
Date: Wed Jan 21 01:43:00 2015 -0600

    Move oslo.serialization to oslo_serialization namespace

    This is the fifth in a series of changes to move to using
    the new oslo_<library> namespace that is being used for
    oslo libraries.

    There is currently a shim in place that is allowing the old
    oslo.<library> imports to work, but we need to be prepared for
    when the shims go away. Thus, we need patches like this one to
    move to the new namespace.

    This patch also updates our hacking check to ensure that no instances
    of oslo.utils sneak back in.

    Change-Id: Ida0f9512a816d45ec5cae4dc4da4dbc923a67cf4
    Partial-bug: 1409733

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-lbaas (master)

Reviewed: https://review.openstack.org/147245
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=fff9f3787343fca507caffd72ea9779a7a35bfc2
Submitter: Jenkins
Branch: master

commit fff9f3787343fca507caffd72ea9779a7a35bfc2
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Jan 13 00:16:20 2015 +0100

    oslo: migrate to namespace-less import paths

    Oslo project decided to move away from using oslo.* namespace for all their
    libraries, so we should migrate to new import path.

    This patch applies new paths for:
    - oslo.config
    - oslo.db
    - oslo.messaging
    - oslo.serialization
    - oslo.utils

    Hacking check will be added in Neutron once all *aas repositories are converted
    to namespace-less imports.

    Related-Bug: #1409733
    Change-Id: If0dce29a0980206ace9866112be529436194d47e

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-lbaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/152292

Mike Perez (thingee)
Changed in cinder:
milestone: kilo-2 → kilo-3
Kyle Mestery (mestery)
Changed in neutron:
milestone: kilo-2 → kilo-3
Changed in cinder:
assignee: Jay Bryant (jsbryant) → Anish Bhatt (anish7)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/152687
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=cbcda7c7e80e19fd7239f9a835636773a17fbe48
Submitter: Jenkins
Branch: master

commit cbcda7c7e80e19fd7239f9a835636773a17fbe48
Author: Anish Bhatt <email address hidden>
Date: Tue Feb 3 13:19:40 2015 -0800

    Change oslo.* to oslo_*

    Change oslo.db to oslo_db
    Change oslo.config to olso_config
    Change oslo.rootwrap to oslo_rootwrap

    The oslo libraries are moving away from namespace packages.

    Partial-bug: 1409733

    Change-Id: I3429282afa2db4c0b3aa630eb3a0eaece04405ed

Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-lbaas (master)

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: master
Review: https://review.openstack.org/152292
Reason: No work to do in lbaas, all fixed in recent patches in the tree.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-vpnaas (master)

Reviewed: https://review.openstack.org/147240
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=8cf618c8ba61248b2f26c1e34d6c4753de03d06f
Submitter: Jenkins
Branch: master

commit 8cf618c8ba61248b2f26c1e34d6c4753de03d06f
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Jan 13 00:18:07 2015 +0100

    oslo: migrate to namespace-less import paths

    Oslo project decided to move away from using oslo.* namespace for all their
    libraries, so we should migrate to new import path.

    This patch applies new paths for:
    - oslo.config
    - oslo.db
    - oslo.messaging
    - oslo.serialization
    - oslo.utils

    Hacking check will be added in Neutron once all *aas repositories are converted
    to namespace-less imports.

    Related-Bug: #1409733
    Change-Id: If0dce29a0980206ace9866112be529436194d47e

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/147248
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=a87fbf1575b8831d543c1b72f1d75d7f214141f7
Submitter: Jenkins
Branch: master

commit a87fbf1575b8831d543c1b72f1d75d7f214141f7
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Jan 13 00:12:47 2015 +0100

    oslo: migrate to namespace-less import paths

    Oslo project decided to move away from using oslo.* namespace for all their
    libraries, so we should migrate to new import path.

    This patch applies new paths for:
    - oslo.config
    - oslo.db
    - oslo.messaging
    - oslo.serialization
    - oslo.utils

    Hacking check will be added in Neutron once all *aas repositories are converted
    to namespace-less imports.

    Related-Bug: #1409733
    Change-Id: If0dce29a0980206ace9866112be529436194d47e

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/147215
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7a2a85623da4d296c5dfe5dc8b6fdb772d74ce92
Submitter: Jenkins
Branch: master

commit 7a2a85623da4d296c5dfe5dc8b6fdb772d74ce92
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Jan 8 17:25:23 2015 +0100

    oslo: migrate to namespace-less import paths

    Oslo project decided to move away from using oslo.* namespace for all their
    libraries [1], so we should migrate to new import path.

    This patch applies new paths for:
    - oslo.config
    - oslo.db
    - oslo.i18n
    - oslo.messaging
    - oslo.middleware
    - oslo.rootwrap
    - oslo.serialization
    - oslo.utils

    Added hacking check to enforce new import paths for all oslo libraries.

    Updated setup.cfg entry points.

    We'll cleanup old imports from oslo-incubator modules on demand or
    if/when oslo officially deprecates old namespace in one of the next
    cycles.

    [1]: https://blueprints.launchpad.net/oslo-incubator/+spec/drop-namespace-packages

    Depends-On: https://review.openstack.org/#/c/147248/
    Depends-On: https://review.openstack.org/#/c/152292/
    Depends-On: https://review.openstack.org/#/c/147240/

    Closes-Bug: #1409733
    Change-Id: If0dce29a0980206ace9866112be529436194d47e

Changed in neutron:
status: In Progress → Fix Committed
Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-neutronclient (master)

Change abandoned by Kyle Mestery (<email address hidden>) on branch: master
Review: https://review.openstack.org/148480
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/160624

Changed in cinder:
assignee: Anish Bhatt (anish7) → Jay Bryant (jsbryant)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/160624
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=00cb3734aed8236c03f067aae9c72616001d89f6
Submitter: Jenkins
Branch: master

commit 00cb3734aed8236c03f067aae9c72616001d89f6
Author: Jay S. Bryant <email address hidden>
Date: Mon Mar 2 21:31:46 2015 -0600

    Move oslo.messaging to the oslo_messaging namespace

    This is the sixth in a series of changes to move to using
    the new oslo_<library> namespace that is being used for
    oslo libraries.

    There is currently a shim in place that is allowing the old
    oslo.<library> imports to work, but we need to be prepared for
    when the shims go away. Thus we need patches like this one to
    move to the new namespace.

    This patch also updates our hacking check to ensure that no
    instances of oslo.messaging sneak back in.

    Change-Id: Id028f8968717bed49386864081cf150397a6ec5f
    Partial-bug: 1409733

Liyingjun (liyingjun)
Changed in glance:
assignee: nobody → Liyingjun (liyingjun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165028

Changed in glance:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165724

Changed in cinder:
assignee: Jay Bryant (jsbryant) → Anish Bhatt (anish7)
Masco (masco)
Changed in python-neutronclient:
assignee: Masco Kaliyamoorthy (masco) → nobody
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Mike Perez (thingee)
Changed in cinder:
milestone: kilo-3 → liberty-1
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Changed in cinder:
assignee: Anish Bhatt (anish7) → Walt Boring (walter-boring)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/165724
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d248cca5e50798616f8dda5d36b550b3542ac6dd
Submitter: Jenkins
Branch: master

commit d248cca5e50798616f8dda5d36b550b3542ac6dd
Author: Anish Bhatt <email address hidden>
Date: Thu Mar 19 01:08:06 2015 -0700

    Change leftover oslo.* to oslo_*

    Use oslo_i18n instead of "from oslo import i18n"
    Use oslo_messaging instead of "from oslo import messaging"

    Partial-Bug: 1409733

    Change-Id: If119603e4f89965d0c9e5917b2772ae0e7ddf3d2

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/165028
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=927ac7cf14eca0e31ecaa74565fd40a88fcf8423
Submitter: Jenkins
Branch: master

commit 927ac7cf14eca0e31ecaa74565fd40a88fcf8423
Author: liyingjun <email address hidden>
Date: Tue Mar 17 19:14:27 2015 +0800

    oslo: migrate namespace-less import paths

    This patch migrates oslo.messaging to oslo_messaging

    Change-Id: I2c0befa48924c6641c8d3af96e7f35ff92e73e4c
    Closes-bug: #1409733

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: kilo-rc1 → 2015.1.0
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-2 → 2015.1.0
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
Changed in cinder:
assignee: Walt Boring (walter-boring) → nobody
Revision history for this message
Jay Bryant (jsbryant) wrote :

Not sure why this was assigned to Walt. I think this work is mostly done. Need to just go through and make sure.

Changed in cinder:
assignee: nobody → Jay Bryant (jsbryant)
Jay Bryant (jsbryant)
Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Jay Bryant (jsbryant) wrote :

We can consider this done. The only remaining exceptions are related to updates that need to be made in cinder/openstack/common . Those will happen as part of the work in: https://bugs.launchpad.net/cinder/+bug/1381563

Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-1 → 7.0.0
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

This bug is > 180 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in python-neutronclient:
status: In Progress → Incomplete
Akihiro Motoki (amotoki)
no longer affects: python-neutronclient
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers