cinder using obsolete oslo modules

[Duncan Thomas]

As noted by Doug Hellmann, the following oslo modules have been graduated to libraries and will no longer be receiving support/maintainance.

openstack/cinder: config.generator
openstack/cinder: excutils
openstack/cinder: gettextutils
openstack/cinder: importutils
openstack/cinder: jsonutils
openstack/cinder: log_handler
openstack/cinder: network_utils
openstack/cinder: strutils
openstack/cinder: timeutils
openstack/cinder: units

To quote:
These modules have been deleted, and now only exist in the stable/juno branch of the incubator. We do not anticipate back-porting fixes except for serious security concerns, so it is important to update all projects to use the libraries where the modules now live.

Liaisons, please look through the list below and file bugs against your project for any changes needed to move to the new libraries and start working on the updates. We need to prioritize this work for early in Kilo to ensure that your projects do not fall further out of step. K-1 is the ideal target, with K-2 as an absolute latest date. I anticipate having several more libraries by the time the K-2 milestone arrives.

Most of the porting work involves adding dependencies and updating import statements, but check the documentation for each library for any special guidance. Also, because the incubator is updated to use our released libraries, you may end up having to port to several libraries *and* sync a copy of any remaining incubator dependencies that have not graduated all in a single patch in order to have a working copy. I suggest giving your review teams a heads-up about what to expect to avoid -2 for the scope of the patch.

Cinder should either make them internal cinder utilities, or use the library version, as appropriate.

[Jay Bryant (jsbryant)]

Duncan,

Thanks for getting the bug open for this. Mike pointed me at this earlier this week and I had been meaning to get a bug opened. I hope to start pushing patches for these soon.

[Jay Bryant (jsbryant)]

This review: https://review.openstack.org/#/c/133409/ took care of the following:

openstack/cinder: excutils
openstack/cinder: network_utils
openstack/cinder: strutils
openstack/cinder: timeutils
openstack/cinder: units

[Jay Bryant (jsbryant)]

This review: https://review.openstack.org/#/c/133478/ took care of the following:

openstack/cinder: processutils
openstack/cinder: lockutils

[Jay Bryant (jsbryant)]

I think everything else is taken care of here: https://review.openstack.org/#/c/133453/

Once those have merged I will go through and make sure we are all up to date.

[Jay Bryant (jsbryant)]

Just an update on this bug. I have been working on getting this done. I have two more libraries that require the namespace change and two more commits for updating the oslo-incubator code. At that point I will be able to complete this piece of cleanup. I have that work targetted for first thing in Kilo-3.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/157441
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5980da5d889de62d6accd6cb002029f8aec4b6a2
Submitter: Jenkins
Branch: master

commit 5980da5d889de62d6accd6cb002029f8aec4b6a2
Author: Ivan Kolodyazhny <email address hidden>
Date: Thu Feb 19 18:43:42 2015 +0200

    Use oslo.log instead of oslo-incubator

    log module was removed from oslo-incubator after oslo.log released.

    Change-Id: I205d0625c502cb462919edc76d12091edcc21b1b
    Implements: blueprint port-oslo-incubator-to-oslo-log
    Partial-Bug: #1381563

[Jay Bryant (jsbryant)]

I had forgotten that we had this bug out there. I have two final patches that wrap this bug up that are currently in the gate:

https://review.openstack.org/165431 - Removes config.generator and moves to the new olso-config-generator
https://review.openstack.org/165572 - Removes the unused gettextutils.

Once those are merged we can close this.

[Jay Bryant (jsbryant)]

Moving this to L-2. :-) It is really an ongoing effort.

We just merged a patch to move to oslo.policy. I also need to put up a patch to move to oslo.service.

So, the other open items that remain are:

openstack/cinder: config.generator (potentially a big chunk of work)
openstack/cinder: gettextutils

Getting this all cleaned up is a priority for Liberty.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/219700
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=111a056c0f212ed38ff6127f6c9b9dc13fd536f0
Submitter: Jenkins
Branch: master

commit 111a056c0f212ed38ff6127f6c9b9dc13fd536f0
Author: Kendall Nelson <email address hidden>
Date: Thu Aug 13 10:17:36 2015 -0500

    Dynamically create cinder.conf.sample

    As it stands, the opts.py file that is passed into
    oslo-config-generator isn't being generated dynamically
    and the old way of generating the cinder.conf.sample is
    dependent on oslo-incubator which Cinder is trying to
    move away from. oslo-config-generator works differently
    than oslo-incubator so a number of changes had to be made
    in order to make this switch.

    This patch adds the config directory to Cinder and in it
    are two files:

        -generate_cinder_opts.py that will take the
         results of a grep command to create the opts.py
         file to be passed into oslo-config-generator.

        -cinder.conf which is the new configuration for
         oslo-config-generator. The file is inside the config
         directory to be consistent with other projects.

    Some changes were made to the generate_sample.sh file in
    order to give the base directories and target directories
    to the generate_cinder_opts.py program.

    tox.ini was edited to remove the checkonly option because
    all that needs to happen in check_uptodate.sh is a check to
    ensure that the cinder.conf.sample is actually being
    generated with no issues.

    All options were removed from the check_uptodate.sh
    because they were unnecessary given the new, more simple
    way of generating the cinder.conf.sample.

    setup.cfg was also edited in order to add information
    oslo-config-generator needs to run.

    Co-Authored By: Jay Bryant <email address hidden>
    Co-Authored By: Jacob Gregor <email address hidden>

    Change-Id: I643dbe5675ae9280e204f691781e617266f570d5
    Closes-Bug: 1473768
    Closes-Bug: 1437904
    Closes-Bug: 1381563

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/225978

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/225978
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0ed1bae46f8bb65130985cbb1eb7b14cd1199379
Submitter: Jenkins
Branch: master

commit 0ed1bae46f8bb65130985cbb1eb7b14cd1199379
Author: Jay S Bryant <email address hidden>
Date: Fri Oct 16 15:21:27 2015 -0500

    Remove unused gettextutils from oslo-incubator

    Now that the old config generator code has been replaced/removed
    we can now also remove gettextutils. The generator was the last
    hold-out in our code still using that obsolete code.

    This patch removes the unneeded file and also updates the i18n code
    that was monkey patching in support for using the _() and _LX()
    functions in gettextutils.

    Change-Id: Ib29915b13bd7f0173637ac6d1881f1ca06b713d6
    related-bug: 1381563