As written, msg is a tuple, and the various logging lines below print
the tuple members without properly expanding the format string as
intended.
The format in msg should have been expanded using % - as was presumably
the intention. This change fixes this and a similar example elsewhere
in this file.
Reviewed: https:/ /review. openstack. org/143353 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=96f40c2c80e ee96dc9475d17a7 248eeb78ccc383
Committed: https:/
Submitter: Jenkins
Branch: master
commit 96f40c2c80eee96 dc9475d17a7248e eb78ccc383
Author: Angus Lees <email address hidden>
Date: Mon Dec 22 15:11:07 2014 +1100
Cisco: logging incorrectly called with (fmt, arg) tuple
cisco. db.n1kv_ db_v2._ validate_ segment_ range_uniquenes s() includes these
lines:
msg = (_("NetworkProfile name %s already exists"),
net_p[" name"])
LOG.error( msg) put(error_ message= msg)
raise n_exc.InvalidIn
As written, msg is a tuple, and the various logging lines below print
the tuple members without properly expanding the format string as
intended.
The format in msg should have been expanded using % - as was presumably
the intention. This change fixes this and a similar example elsewhere
in this file.
Change-Id: I993245a18ff3db 5d5700fb1298ffc 958d5827736
Closes-Bug: #1404785