commit 6a9d1121472028f3583e577b62a7e576fff5806f
Author: Mike Bayer <email address hidden>
Date: Sun Nov 30 22:18:32 2014 -0500
Alter execute_alembic_command() to not assume all commands
Alembic 0.7.1 is adding new diff directives add_fk and remove_fk.
The logic in execute_alembic_command() appears to assume all potential
commands are present in METHODS. This patch adjusts it so that
it checks METHODS first, allowing the tests in neutron.tests.unit.db.test_migration
to pass. However, if the design here requires that all potential
Alembic commands are handled, then this would not be the fix,
though I recommend that the potential list of Alembic directives
not be hardcoded.
Reviewed: https:/ /review. openstack. org/137989 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=6a9d1121472 028f3583e577b62 a7e576fff5806f
Committed: https:/
Submitter: Jenkins
Branch: master
commit 6a9d1121472028f 3583e577b62a7e5 76fff5806f
Author: Mike Bayer <email address hidden>
Date: Sun Nov 30 22:18:32 2014 -0500
Alter execute_ alembic_ command( ) to not assume all commands
Alembic 0.7.1 is adding new diff directives add_fk and remove_fk. alembic_ command( ) appears to assume all potential tests.unit. db.test_ migration
The logic in execute_
commands are present in METHODS. This patch adjusts it so that
it checks METHODS first, allowing the tests in neutron.
to pass. However, if the design here requires that all potential
Alembic commands are handled, then this would not be the fix,
though I recommend that the potential list of Alembic directives
not be hardcoded.
Change-Id: Ib08685be252e1f db0f10853f8fc9a 7e19ac54a94
Closes-Bug: #1397796