neutron

  1. Bug #1365829
  2. Comment #5

Comment 5 for bug 1365829

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/119358
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=74a292ceba0be6aaa7ea1911cac2f102eb3db90e
Submitter: Jenkins
Branch: master

commit 74a292ceba0be6aaa7ea1911cac2f102eb3db90e
Author: Miguel Angel Ajo <email address hidden>
Date: Fri Sep 5 14:10:35 2014 +0200

    Avoid testing code duplication which introduced testing bugs

    SecurityGroupAgentEnhancedRpcTestCase duplicated code in
    SecurityGroupAgentRpcTestCase setUp, also
    TestSecurityGroupAgentEnhancedRpcWithIptables duplicated
    code from TestSecurityGroupAgentWithIptables setUp()
    introducing bugs by improper initialization, like a missing
        self.iptables.use_ipv6 = True
    which in combination with tests.unit.test_ipv6.TestIsEnabled
    produced inconsistent testing results.

    Change-Id: Ic0b596b6fe1d8273df197e9426abad818832c00a
    Closes-bug: #1365829