Fix UnboundLocalError raised during L3 router sync task
This can be fixed in a number of ways: a) consolidating the
two except clauses into one; b) adding a 'return' after the
last except clause c) by calling the cleanup method only on
success; d) initializing 'routers' before usage.
Approach c) has the benefit of stating the developer's intent
more explicitly and minimize chances of regression.
Reviewed: https:/ /review. openstack. org/104006 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=fc01ddaaa5f 1170b746f478371 04352bfe36eaa5
Committed: https:/
Submitter: Jenkins
Branch: master
commit fc01ddaaa5f1170 b746f4783710435 2bfe36eaa5
Author: armando-migliaccio <email address hidden>
Date: Tue Jul 1 15:08:11 2014 -0700
Fix UnboundLocalError raised during L3 router sync task
This can be fixed in a number of ways: a) consolidating the
two except clauses into one; b) adding a 'return' after the
last except clause c) by calling the cleanup method only on
success; d) initializing 'routers' before usage.
Approach c) has the benefit of stating the developer's intent
more explicitly and minimize chances of regression.
Closes-bug: #1336566
Change-Id: Ib91ac5bb07869c bec6825b60d7c4c 5b23c4c4d3a