Comment 2 for bug 1326256

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/99387
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8fb69a4633e87446eadd7f0173a0168f78604cbe
Submitter: Jenkins
Branch: master

commit 8fb69a4633e87446eadd7f0173a0168f78604cbe
Author: Bertrand Lallau <email address hidden>
Date: Wed Jun 11 15:46:58 2014 +0200

    Dnsmasq config files syntax issue when dhcp_domain is empty

    When using dhcp-agent with the following property dhcp_domain=""
    addn_hosts and host files genererated for Dnsmasq have wrong syntax
    concerning hostname parameter (dot char at the end).

    As described in RFC-952 the hostname grammar is as follows:
    <hname> ::= <name>*["."<name>]
    <name> ::= <let>[*[<let-or-digit-or-hyphen>]<let-or-digit>]
    Hence it can't be conclude with a dot char.

    Dnsmasq process is waiting for a hostname (2nd parameter) in the
    following files:
    "addn_hosts" file contains:
       20.0.0.3 host-20-0-0-3. host-20-0-0-3
    "host" file contains:
       fa:16:3e:bf:e1:e4,host-20-0-0-3.,20.0.0.3

    With the patch you will get:
    "addn_hosts":
       20.0.0.3 host-20-0-0-3 host-20-0-0-3
    "host":
       fa:16:3e:bf:e1:e4,host-20-0-0-3,20.0.0.3

    Change-Id: I4c10169019becaed6b2968b74f03ef356244a057
    Closes-Bug: #1326256