Comment 12 for bug 1319232

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cinder (master)

Reviewed: https://review.openstack.org/96512
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=132c4530713a6f404ce5ed01a9668519d69afe16
Submitter: Jenkins
Branch: master

commit 132c4530713a6f404ce5ed01a9668519d69afe16
Author: Matt Riedemann <email address hidden>
Date: Thu May 29 08:45:55 2014 -0700

    Sync periodic_task from oslo-incubator

    This is more or less to get commit c63fd5a from oslo into the core
    projects which have several periodic tasks. Cinder has periodic tasks
    to sync up volume state with the server and they don't have specific
    spacing values set which can lead to non-deterministic spacing of when
    the tasks run.

    Note that this does not include the gettextutils and log dependencies
    since there are not functional changes in those modules needed for the
    periodic_task changes synced in *and* more importantly, the changes
    to gettextutils and log require pervasive changes to cinder which
    should happen when cinder integrates with the oslo-i18n library for
    blueprint i18n--messages.

    Further note that this does not include jsonutils due to some
    issues introduced with a change for python 2.6 that impacts how strings
    are encoded with simplejson. The details for that issue are in bug
    1314129. The jsonutils changes are not related to the periodic_task
    changes being synced in so the dependency is not functionally required.

    cinder.db.base.Base is also updated otherwise multiple inheritance
    involving that class will not work, which impacts all of the classes
    that extend cinder.manager.Manager which extends both cinder.db.Base
    and PeriodicTasks, and commit 47c9d60 adds attributes to the __init__
    for PeriodicTasks. Nova had the same change with commit 5ae97ea.

    Changes:

    c63fd5a Make unspecified periodic spaced tasks run on default interval
    f0dd798 Remove rendundant parentheses of cfg help strings
    fcf517d Update oslo log messages with translation domains
    051b9f3 Refactor unnecessary arithmetic ops in periodic_task
    674cdaf Refactor if logic in periodic_task
    b6b82c5 Use timestamp in periodic tasks
    47c9d60 Don't share periodic_task instance data in a class attr
    8b2b0b7 Use hacking import_exceptions for gettextutils._
    c5a1088 Typos fix in db and periodic_task module
    12bcdb7 Remove vim header

    Related-Bug: #1319232

    Change-Id: I13e8ac83bcd9e60a8eb05ed9cdfea00b9e5fb398