Comment 5 for bug 1314534

Revision history for this message
Darragh O'Reilly (darragh-oreilly) wrote :

I'm not sure about the process for removing a call from the RPC API. It probably depends on whether the server or the agents get upgraded first.
If the server is upgraded first, then it would need to be backward compatible with the agents from the previous release. So if this change is merged in Juno, then the server side code should not be removed until K.

The unused code is here:

vagrant@devstack:/opt/stack/neutron$ grep -r get_dhcp_port\( neutron/
neutron/db/dhcp_rpc_base.py: def get_dhcp_port(self, context, **kwargs):
neutron/agent/dhcp_agent.py: def get_dhcp_port(self, network_id, device_id):
neutron/tests/unit/test_dhcp_agent.py: def test_get_dhcp_port(self):
neutron/tests/unit/test_dhcp_agent.py: retval = self.proxy.get_dhcp_port('netid', 'devid')
neutron/tests/unit/test_dhcp_agent.py: self.assertIsNone(self.proxy.get_dhcp_port('netid', 'devid'))
neutron/tests/unit/test_db_rpc_base.py: retval = self.callbacks.get_dhcp_port(mock.Mock(),