E711 comparison to False should be 'if cond is False:' or 'if not cond:'
comparison to None should be 'if cond is None:' or 'if not cond:'
E712 comparison to True should be 'if cond is True:' or 'if cond:'
Most violations were in DB queries. Replace as follows:
False -> sqlalchemy.sql.false()
None -> sqlalchemy.sql.null()
True -> sqlalchemy.sql.true()
Reviewed: https:/ /review. openstack. org/86494 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=dda6c89202b 015628f74101839 301424001a6c63
Committed: https:/
Submitter: Jenkins
Branch: master
commit dda6c89202b0156 28f741018393014 24001a6c63
Author: Henry Gessau <email address hidden>
Date: Wed Apr 9 22:49:50 2014 -0400
Enable flake8 E711 and E712 checking
E711 comparison to False should be 'if cond is False:' or 'if not cond:'
comparison to None should be 'if cond is None:' or 'if not cond:'
E712 comparison to True should be 'if cond is True:' or 'if cond:'
Most violations were in DB queries. Replace as follows: sql.false( ) sql.null( ) sql.true( )
False -> sqlalchemy.
None -> sqlalchemy.
True -> sqlalchemy.
Change-Id: Iff54747b70f504 d5466cfdc6e2ec4 d7a0f9ddb7c
Closes-bug: #1305377