neutron

  1. Bug #1300265
  2. Comment #1

Comment 1 for bug 1300265

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/123430
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e40c2ed58ce998fc5aba83ffae8ebefec9403c3b
Submitter: Jenkins
Branch: master

commit e40c2ed58ce998fc5aba83ffae8ebefec9403c3b
Author: Jacek Swiderski <email address hidden>
Date: Tue Sep 23 14:35:06 2014 +0200

    mock.assert_called_once() is not a valid method

    mock.assert_called_once() is a no-op that tests nothing. Instead
    mock.assert_called_once_with() should be used (or use
    assertEqual(1, mock_obj.call_count) if you don't want to check
    parameters).

    Borrowed HACKING rule from Davanum Srinivas's nova patch to
    prevent it from appearing again.

    Change-Id: Idac1d3c89c07e13c9a209663f4e557fcb7547821
    Closes-Bug: #1365751
    Closes-Bug: #1300265