I reviewed the fix and confirmed it works as expected.
The change looks good (it is worth +2).
One minor nit on a comment.
> neutron/tests/unit/test_l3_plugin.py
> class L3AgentDbTestCaseBase(L3NatTestCaseMixin):
> + # create a network owned by a normal tenant
I think it is better to change "a normal tenant" to "another tenant".
router is created by a default tenant ("test-tenant" is the default tenant is UT)
and 'tenant' tenant is a different tenant.
(Beyond this fix, it may be better to discuss who can specify/update device_owner/device_id? Now anyone can update device_id/device_owner of his/her ports, but it may be better only admin can specify them.)
I reviewed the fix and confirmed it works as expected.
The change looks good (it is worth +2).
One minor nit on a comment.
> neutron/ tests/unit/ test_l3_ plugin. py seBase( L3NatTestCaseMi xin):
> class L3AgentDbTestCa
> + # create a network owned by a normal tenant
I think it is better to change "a normal tenant" to "another tenant".
router is created by a default tenant ("test-tenant" is the default tenant is UT)
and 'tenant' tenant is a different tenant.
(Beyond this fix, it may be better to discuss who can specify/update device_ owner/device_ id? Now anyone can update device_ id/device_ owner of his/her ports, but it may be better only admin can specify them.)