neutron

  1. Bug #1243327
  2. Comment #8

Comment 8 for bug 1243327

Revision history for this message
Akihiro Motoki (amotoki) wrote : Re: Routers can be cross plugged by other tenants

I reviewed the fix and confirmed it works as expected.

The change looks good (it is worth +2).
One minor nit on a comment.

> neutron/tests/unit/test_l3_plugin.py
> class L3AgentDbTestCaseBase(L3NatTestCaseMixin):
> + # create a network owned by a normal tenant

I think it is better to change "a normal tenant" to "another tenant".
router is created by a default tenant ("test-tenant" is the default tenant is UT)
and 'tenant' tenant is a different tenant.

(Beyond this fix, it may be better to discuss who can specify/update device_owner/device_id? Now anyone can update device_id/device_owner of his/her ports, but it may be better only admin can specify them.)