Comment 22 for bug 1235450
Revision history for this message
| Russell Bryant (russellb) wrote Re: Metadata is unsecure | #22 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
e3ace39
(Get the code!)
Nova patch comments:
1) Since this is going into stable, do you think we should make it handle the case of a missing X-Tenant-ID header not fail the request?
2)
+ elif not isinstance(
+ msg = _('Multiple X-Tenant-ID headers found within request.')
Would checking if tenant_id is a list be a more explicit check for the msg you are assigning to it? I see that it's just a copy of the handling for another header, so I guess it's fine to just leave it as-is.
Otherwise, patch seems fine to me. Thanks!