Comment 2 for bug 1190620

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/58125
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b6a8aea4d1fe8be6073af57fad2ab6863d8f359c
Submitter: Jenkins
Branch: master

commit b6a8aea4d1fe8be6073af57fad2ab6863d8f359c
Author: Dane LeBlanc <email address hidden>
Date: Thu Nov 21 12:34:57 2013 -0500

    Improve unit test coverage for Cisco plugin model code

    Closes-Bug: #1190620

    This fix improves unit test coverage for:
    quantum/plugins/cisco/models/virt_phy_sw_v2.py
    Test coverage is improved from about 78% to 99%.

    One change included in this fix is removal of some code in
    the _invoke_plugin() method in virt_phy_sw_v2.py which looks
    like it's attempting to handle the case where the number of
    arguments being passed to _invoke_plugin() exceeds the number
    of arguments expected for the target plugin method. This
    section of code does not get executed for any existing
    calls to _invoke_plugin(), and it doesn't appear that
    this logic would work (except when the target plugin method
    includes a **kwargs expansion).

    Change-Id: Ibceb7a462a213f3ba693bcbe94e77d97b2e1440a