Comment 3 for bug 1675289

Revision history for this message
Bernard Cafarelli (bcafarel) wrote :

Pasting my comment from the review:
From what I just checked, setting selection_method requires OpenFlow1.5.
You can check by manually running ovs-ofctl commands, the selection_method will not appear in a later dump-groups call.

Additionally, this does not address the bug itself, as the fields field itself is not visible in the ovs groups (this requires OpenFlow 1.5 too)

And now I am wondering, do we actually pass lb_fields to the OVS driver? I do not see that in the code. And I am a little worried about this one, it sounds too OVS-specific, how do other drivers react to something like fields=ip_src,ip_dst?

OK, so to fix it here:
* looks like OpenFlow 1.5 is needed here
* selection_method is not set (Ching Sun's patch)
* lb_fields are not passed either (including the default ones we should use)
* some load balancing tests would help too to monitor this kind of problems

Thoughts?