Comment 13 for bug 1587486

Reviewed: https://review.openstack.org/468937
Committed: https://git.openstack.org/cgit/openstack/networking-sfc/commit/?id=cd2e9274e9ec3d19ec84eb5b70416f72dd14391f
Submitter: Jenkins
Branch: master

commit cd2e9274e9ec3d19ec84eb5b70416f72dd14391f
Author: Igor Duarte Cardoso <email address hidden>
Date: Mon May 29 16:53:39 2017 +0000

    OVS Driver tests: scope Flow Rules to Port Chains

    OVS Driver tests make use of the build_ingress_egress() method to
    create a dictionary of all the flow rules that would be passed to the
    OVS agent. This patches invites the Port Chain ID to be used as a
    an argument of build_ingress_egress() in order to scope them per
    Port Chain.

    Previously, multiple flow rules would get clumped together (with
    loss of detail) in some scenarios, e.g. multiple Port Chains sharing
    the same logical source port (via the attached Flow Classifiers).
    This would then difficult testing or provide an incorrect view to the
    test developer, increasing the chance of mistakes.

    Additionally, other related changes were made:
    - Removed unused build_ingress_egress_list() method.
    - Renamed "flows" to "flow_rule" in OVS Driver's rpc.py to be less
      confusing about what's actually being passed.
    - Adapted existing tests to use the new build_ingress_egress().
    - Other small cleanups.

    Partial-Bug: #1587486
    Change-Id: Ic87623b266a2279baf0e2056b9432e984f61739b