Each octavia provider driver unittest and functional test fails on:
ft1.1: networking_ovn.tests.unit.octavia.test_ovn_driver.TestOvnProviderDriver.test_loadbalancer_failover_StringException: Traceback (most recent call last):
File "networking_ovn/tests/unit/octavia/test_ovn_driver.py", line 74, in setUp
self.driver = ovn_driver.OvnProviderDriver()
File "networking_ovn/octavia/ovn_driver.py", line 1554, in __init__
self._ovn_helper = OvnProviderHelper()
File "networking_ovn/octavia/ovn_driver.py", line 189, in __init__
self._octavia_driver_lib = o_driver_lib.DriverLibrary()
File "/home/zuul/src/opendev.org/openstack/networking-ovn/.tox/py27/local/lib/python2.7/site-packages/octavia_lib/api/drivers/driver_lib.py", line 53, in __init__
self._check_for_socket_ready(status_socket)
File "/home/zuul/src/opendev.org/openstack/networking-ovn/.tox/py27/local/lib/python2.7/site-packages/tenacity/__init__.py", line 292, in wrapped_f
return self.call(f, *args, **kw)
File "/home/zuul/src/opendev.org/openstack/networking-ovn/.tox/py27/local/lib/python2.7/site-packages/tenacity/__init__.py", line 358, in call
do = self.iter(retry_state=retry_state)
File "/home/zuul/src/opendev.org/openstack/networking-ovn/.tox/py27/local/lib/python2.7/site-packages/tenacity/__init__.py", line 331, in iter
raise retry_exc.reraise()
File "/home/zuul/src/opendev.org/openstack/networking-ovn/.tox/py27/local/lib/python2.7/site-packages/tenacity/__init__.py", line 167, in reraise
raise self.last_attempt.result()
File "/home/zuul/src/opendev.org/openstack/networking-ovn/.tox/py27/local/lib/python2.7/site-packages/concurrent/futures/_base.py", line 455, in result
return self.__get_result()
File "/home/zuul/src/opendev.org/openstack/networking-ovn/.tox/py27/local/lib/python2.7/site-packages/tenacity/__init__.py", line 361, in call
result = fn(*args, **kwargs)
File "/home/zuul/src/opendev.org/openstack/networking-ovn/.tox/py27/local/lib/python2.7/site-packages/octavia_lib/api/drivers/driver_lib.py", line 44, in _check_for_socket_ready
'socket: {}'.format(socket)))
octavia_lib.api.drivers.exceptions.DriverAgentNotFound: Unable to open the driver agent socket: /var/run/octavia/status.sock
Reviewed: https:/ /review. opendev. org/674574 /git.openstack. org/cgit/ openstack/ networking- ovn/commit/ ?id=b2b5e89bca2 5570a757c62fc6e 30277365dae456
Committed: https:/
Submitter: Zuul
Branch: master
commit b2b5e89bca25570 a757c62fc6e3027 7365dae456
Author: Maciej Józefczyk <email address hidden>
Date: Thu Aug 8 12:25:13 2019 +0000
Fix gateway blockers
This patch squaches two commits:
1) Do not modify passed by reference variables in mechanism_driver
Test test_update_ port_with_ empty_data [0] from TestOVNMechanis mDriverPortsV2 tests.unit. plugins. ml2.drivers. mechanism_ test.TestMechan ismDriver port_postcommit () does nothing with
class in neutron is runned agains:
neutron.
which in fact during update_
the port, only validates it [1].
In networking-ovn this test is runned against real mechanism driver: ovn.ml2. mech_driver. OVNMechanismDri ver. This ends with port_postcommit (). The port data itself
networking_
little difference - to port dict 'network' information is added
during call of update_
remains the same.
We shouldn't modify passed by reference variables there. So doing
deepcopy on all provided data.
Here comes also the question if this test inheritance is the
right way.
2) Add mock for _check_ for_socket_ ready
Recently in new octavia-lib release driver-lib provides
get methods for quering objects by its ids [2].
We need to mock() socket communication in tests, otherwise
all the tests fails blocking CI.
[0] https:/ /review. opendev. org/#/c/ 673486 /github. com/openstack/ neutron/ blob/master/ neutron/ tests/unit/ plugins/ ml2/drivers/ mechanism_ test.py# L208 /github. com/openstack/ octavia- lib/commit/ d700c00a90fd62b 4f6cb9eb30ebe5f 619dd6bfda
[1] https:/
[2] https:/
Related-Bug: #1838977 896f6eb8049a188 d9e82874068
Closes-Bug: #1839434
Change-Id: I1ad224960173fe