commit b2b5e89bca25570a757c62fc6e30277365dae456
Author: Maciej Józefczyk <email address hidden>
Date: Thu Aug 8 12:25:13 2019 +0000
Fix gateway blockers
This patch squaches two commits:
1) Do not modify passed by reference variables in mechanism_driver
Test test_update_port_with_empty_data [0] from TestOVNMechanismDriverPortsV2
class in neutron is runned agains:
neutron.tests.unit.plugins.ml2.drivers.mechanism_test.TestMechanismDriver
which in fact during update_port_postcommit() does nothing with
the port, only validates it [1].
In networking-ovn this test is runned against real mechanism driver:
networking_ovn.ml2.mech_driver.OVNMechanismDriver. This ends with
little difference - to port dict 'network' information is added
during call of update_port_postcommit(). The port data itself
remains the same.
We shouldn't modify passed by reference variables there. So doing
deepcopy on all provided data.
Here comes also the question if this test inheritance is the
right way.
2) Add mock for _check_for_socket_ready
Recently in new octavia-lib release driver-lib provides
get methods for quering objects by its ids [2].
We need to mock() socket communication in tests, otherwise
all the tests fails blocking CI.
Reviewed: https:/ /review. opendev. org/674574 /git.openstack. org/cgit/ openstack/ networking- ovn/commit/ ?id=b2b5e89bca2 5570a757c62fc6e 30277365dae456
Committed: https:/
Submitter: Zuul
Branch: master
commit b2b5e89bca25570 a757c62fc6e3027 7365dae456
Author: Maciej Józefczyk <email address hidden>
Date: Thu Aug 8 12:25:13 2019 +0000
Fix gateway blockers
This patch squaches two commits:
1) Do not modify passed by reference variables in mechanism_driver
Test test_update_ port_with_ empty_data [0] from TestOVNMechanis mDriverPortsV2 tests.unit. plugins. ml2.drivers. mechanism_ test.TestMechan ismDriver port_postcommit () does nothing with
class in neutron is runned agains:
neutron.
which in fact during update_
the port, only validates it [1].
In networking-ovn this test is runned against real mechanism driver: ovn.ml2. mech_driver. OVNMechanismDri ver. This ends with port_postcommit (). The port data itself
networking_
little difference - to port dict 'network' information is added
during call of update_
remains the same.
We shouldn't modify passed by reference variables there. So doing
deepcopy on all provided data.
Here comes also the question if this test inheritance is the
right way.
2) Add mock for _check_ for_socket_ ready
Recently in new octavia-lib release driver-lib provides
get methods for quering objects by its ids [2].
We need to mock() socket communication in tests, otherwise
all the tests fails blocking CI.
[0] https:/ /review. opendev. org/#/c/ 673486 /github. com/openstack/ neutron/ blob/master/ neutron/ tests/unit/ plugins/ ml2/drivers/ mechanism_ test.py# L208 /github. com/openstack/ octavia- lib/commit/ d700c00a90fd62b 4f6cb9eb30ebe5f 619dd6bfda
[1] https:/
[2] https:/
Related-Bug: #1838977 896f6eb8049a188 d9e82874068
Closes-Bug: #1839434
Change-Id: I1ad224960173fe