Comment 1 for bug 1589807

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-ovn (master)

Reviewed: https://review.openstack.org/325733
Committed: https://git.openstack.org/cgit/openstack/networking-ovn/commit/?id=80745bc1c5c1fc78172a853a6370661261f8cf23
Submitter: Jenkins
Branch: master

commit 80745bc1c5c1fc78172a853a6370661261f8cf23
Author: lzklibj <email address hidden>
Date: Mon Jun 6 13:58:22 2016 +0800

    Fix port range for icmp type

    In method acl_protocol_and_ports method, it's using
    "ICMPX.type >= Type-code" and "ICMPX.type <= Type-code", where ICMPX
    could be "icmp4" or "icmp6".

    But for ICMP or ICMPv6, port_range_min/max in acl_protocol_and_ports
    should be considered as icmp.type and icmp.code.

    This patch tries to fix that.

    Closes-Bug: #1589807
    Change-Id: I634095ad3a6cf1c723767ff7ea2814f692e0931e