Comment 13 for bug 1771092

Reviewed: https://review.openstack.org/590421
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=abd9ea280042b1dd1bc76bdff9aa05b7a284dfdb
Submitter: Zuul
Branch: stable/ocata

commit abd9ea280042b1dd1bc76bdff9aa05b7a284dfdb
Author: YAMAMOTO Takashi <email address hidden>
Date: Mon Jun 4 19:07:27 2018 +0900

    Fix sphinx-docs job

    build-openstack-sphinx-docs jobs fail on all branches due to the new
    pip version 10 introduces some previously Warning as Error: in case of
    calling "pip install" without any package name, the command fails.
    tox_install.sh is called during docs job without any package passed to pip.

    Note: This commit includes the following unrelated changes
    to pass the gate.
    (Actually I2d125ce2251473f896fc251b8fa51cfa29721850 might not
    be necessary on this branch. But I included it as it was a part
    of the original commit on master.)
    ----------------------------------------
    Pin rally to 0.12.1

    Rally plugin after version 0.12.1 installs the new and latest
    rally-openstack, which has higher requirements of packages and is not
    constrained by pike's upper-constraints.txt during installation. This
    causes problem on stable/pike and older stable branches: keystone
    service is not able to start (ContextualVersionConflict, see
    screen-keystone.txt)

    The patch that introduced the new behaviour:
    https://review.openstack.org/#/c/575064/4/devstack/lib/rally

    Backport Note(yamamoto): Applied to rally-v2 job too.
    ----------------------------------------
    Disable failing style checks (W503, E402) for now.

    I (yamamoto) guess they are new with pycodestyle 2.4.0.

    Related-Bug: #1762795
    Change-Id: Ib35d0718bf1410dc8e5c10bb185a00837f2d8b52
    ----------------------------------------
    Add dummy docstrings to avoid Sphinx 1.7.x warnings

    We need to workaround this locally because:
    - It's unclear how long os-vif patch [1] will take
      to be merged.
    - While Neutron patch [2] has been merged, docs build on
      gate is using released versions of dependencies.

    The idea was taken from keystone. [3]

    [1] https://review.openstack.org/#/c/577028/
    [2] https://review.openstack.org/#/c/577029/
    [3] https://review.openstack.org/#/c/578121/

    Related-Bug: #1771092
    Change-Id: I2d125ce2251473f896fc251b8fa51cfa29721850
    ----------------------------------------

    Conflicting file:
      tox.ini - from upper-constraints we need stable/ocata here, which is
          already set
      rally-jobs/plugins/network_plugin.py - because rally has to be pinned,
          the "Port rally plugins to use proper modules" part of the
          backport has to be left out
      midonet/neutron/db/l3_db_midonet.py - changed between ocata and pike
      midonet/os_vif/vif_midonet.py - new file in pike, so removed

    Co-Authored-By: eeldill <email address hidden>
    Co-Authored-By: Andrey Kurilin <email address hidden>
    Co-Authored-By: OpenStack Release Bot <email address hidden>
    Co-Authored-By: YAMAMOTO Takashi <email address hidden>
    Change-Id: I69663be876def03f47594c838591cfdb10d00871
    (cherry picked from commit f24c41935cf010e319a8e0e3826f145774a81d6c)
    (cherry picked from commit ae2ed9a6dff37d9b04525643c8fe8dc76766a225)