Hyper-V: Removes extra cases for ingress ICMP rule
Previously, if the egress rule with no protocol specified
was added, the HyperVSecurityGroupsDriver would create an
inbound ICMP rule, in order for ping reply to be received.
This is because ICMP rules cannot be added as stateful on
Hyper-V and ping is expected to work if the rule is egress.
This would also cause the VM to be ping-able, which isn't
desirable.
Removes the special cases where ingress ICMP rules are
created. If ping is desirable, both ingress and egress
rules will have to be added.
Reviewed: https:/ /review. openstack. org/197666 /git.openstack. org/cgit/ stackforge/ networking- hyperv/ commit/ ?id=702d4510593 2e6d35584dea31b b0e742321919f2
Committed: https:/
Submitter: Jenkins
Branch: master
commit 702d45105932e6d 35584dea31bb0e7 42321919f2
Author: Claudiu Belu <email address hidden>
Date: Wed Jul 1 20:04:44 2015 +0300
Hyper-V: Removes extra cases for ingress ICMP rule
Previously, if the egress rule with no protocol specified roupsDriver would create an
was added, the HyperVSecurityG
inbound ICMP rule, in order for ping reply to be received.
This is because ICMP rules cannot be added as stateful on
Hyper-V and ping is expected to work if the rule is egress.
This would also cause the VM to be ping-able, which isn't
desirable.
Removes the special cases where ingress ICMP rules are
created. If ping is desirable, both ingress and egress
rules will have to be added.
Change-Id: If10d1408bf0f3e d487e394edd8e0b 0ea52070a48
Closes-Bug: #1470443