netplan bridge config doesn't support stp boolean

Bug #1665088 reported by Ryan Harper on 2017-02-15
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
netplan
High
Mathieu Trudel-Lapierre
Ubuntu
Undecided
Unassigned

Bug Description

[Impact]
Users of netplan may wish to specify a custom MTU value for a device.

[Test case]
- Run nplan integration tests on the release
- Validate that netplan generate && netplan apply alone, without config, behave as expected (no result)
- Validate that netplan generate && netplan apply with minimal config writes /run/NetworkManager/conf.d/10-globally-managed-devices.conf
- Validate that netplan generate && netplan apply works with any existing configuation.
- Use the config below; ensure behavior is as expected (STP value is set on the interface; adjust device names as appropriate). There should be no errors at applying the requested configuration.

[Regression potential]
Any failure to work with existing configuration should be considered a regression. Any new failure of the test suite would be a regression.

---

networkd supports setting STP value in Bridge type netdevs, but netplan does not accept the key.

root@ubuntu:/etc/netplan# apt-cache policy nplan
nplan:
  Installed: 0.18
  Candidate: 0.18
  Version table:
 *** 0.18 500
        500 http://archive.ubuntu.com/ubuntu zesty/main amd64 Packages
        100 /var/lib/dpkg/status
root@ubuntu:/etc/netplan# lsb_release -rd
Description: Ubuntu Zesty Zapus (development branch)
Release: 17.04

root@ubuntu:/etc/netplan# cat 52-bridge.yaml
network:
    ethernets:
        eth0:
            addresses:
            - 10.11.12.13/24
            match:
                macaddress: '52:54:00:12:34:00'
            set-name: foobar0
        eth1:
            match:
                macaddress: '52:54:00:12:34:02'
            set-name: eth1
        eth2:
            match:
                macaddress: '52:54:00:12:34:04'
            set-name: eth2
    bridges:
        br0:
            addresses:
            - 192.168.14.2/24
            interfaces:
            - eth1
            - eth2
            parameters:
                ageing-time: 250
                priority: 22
                forward-delay: 1
                hello-time: 1
                max-age: 10
                path-cost:
                    eth1: 50
                    eth2: 75
                stp: true
    version: 2

root@ubuntu:/etc/netplan# netplan generate
Error in network definition //etc/netplan/52-bridge.yaml line 24 column 16: unknown key stp

Indeed, this appears to have been omitted. I believe default should be set to true though.

Changed in netplan:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
tags: added: maas
Mike Pontillo (mpontillo) wrote :

MAAS will very soon be generating netplan with the 'stp' boolean, so until a fix lands for this, MAAS is generating broken netplan.

Changed in netplan:
status: Triaged → In Progress

This landed in nplan 0.19:

nplan (0.19) zesty; urgency=medium

  * Add support for unordered definition of network devices: you can now
    specify a virtual devices before their member devices. (LP: #1670495)
  * Allow setting up the STP state for a bridge. (LP: #1665088)
  * Document bond/bridge parameters support. (LP: #1664702)

Changed in netplan:
status: In Progress → Fix Released
description: updated

Hello Ryan, or anyone else affected,

Accepted nplan into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nplan/0.21~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers