Murano doesn't detect pre-installed murano-agent on the debian image

[Serg Melikyan]

Deployment of Apache Server application fails randomly with a message murano-agent is failed to respond within 3600 seconds (IS NOT RELATED TO THIS ISSUE).

Investigation of this particular application with Debian image from apps.openstack.org shows that during VM boot we didn't detected correctly that murano-agent is already installed and tried to install once again but due to missing connectivity to the internet at that point of time installation failed leading to leaving VM in failed state.

Current detection mechanism is based on the search of running process in the memory, but on debian-based images murano-agent is not running after the boot). We need to improve detection of the pre-installed murano-agent and have consistent behavior in all our DIB elements.

Steps to reproduce:
1. Import Apache application from apps.openstack.org
2. Deploy environment with this application using Debian image which is downloaded as part of this application

Expected results: murano-agent is not installed as part of the VM bootstrap

Actual results: murano-agent is tried to be installed (fails is not related to this issue) as part of the VM bootstrap

cloudinit-output.log

Downloading/unpacking murano-agent
  Cannot fetch index base URL https://pypi.python.org/simple/
  Could not find any downloads that satisfy the requirement murano-agent
Cleaning up...
No distributions at all found for murano-agent
Storing debug log for failure in /root/.pip/pip.log

[Nikolay Starodubtsev (starodubcevna)]

So, it's hard to understand what is the bug about:
1) Agent is not identified correctly
2) Broken network connectivity
Can you clarify it, Serg?

[Serg Melikyan (smelikyan)]

this bug is about two things:

 - incorrect detection of pre-installed murano-agent
 - temporary missing internet connectivity during the boot fails whole installation,

[Nikolay Starodubtsev (starodubcevna)]

Serg, I can't verify 'temporary missing internet connectivity`. I have problems with internet, because default_dns was not specified in murano.conf on devstack.
Can you verify or refute my suggestion?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/312502

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/313531

[Serg Melikyan (smelikyan)]

I've updated description to cover only issue with incorrect murano-agent detection, because networking issues looks like related to the Neutron and specific to the concrete setup which is not possible to reproduce anymore.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/314970
Committed: https://git.openstack.org/cgit/openstack/murano-agent/commit/?id=4c28db2e9c0889fcfbbf9db5376d1e53c0314a95
Submitter: Jenkins
Branch: master

commit 4c28db2e9c0889fcfbbf9db5376d1e53c0314a95
Author: Nikolay Starodubtsev <email address hidden>
Date: Wed May 11 14:09:00 2016 +0300

    Install murano-agent to pip default location

    During package build murano-agent was installed into /opt/stack/<smthg>
    directory. This causes problems with the new way of how agent is
    detected by murano.
    Related-Bug: #1570962
    Change-Id: I3dbacb03243d462e9f688e502deec07e33490b30

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/313531
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=15df963544f4dc21492dd8641235081c85ce4025
Submitter: Jenkins
Branch: master

commit 15df963544f4dc21492dd8641235081c85ce4025
Author: Nikolay Starodubtsev <email address hidden>
Date: Fri May 6 15:25:37 2016 +0300

    Change incorrect murano-agent bin file location

    During cloud-init related improvements murano-agent location was
    specified for the pip-style installation. This leads to unability
    to deploy the apps on the images with pre-installed murano-agent
    without network. This commit create a symlink to the pre-installed agent
    in place where pip usually installs packages.

    Change-Id: I8d90d33dc0a1c36ac4524f8f3b82223c23829126
    Closes-Bug: #1570962

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/320401

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/murano 3.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/368488

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/320401
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=383dc3194e1519095d5a0e2394296f15e04918b1
Submitter: Jenkins
Branch: stable/mitaka

commit 383dc3194e1519095d5a0e2394296f15e04918b1
Author: Nikolay Starodubtsev <email address hidden>
Date: Fri May 6 15:25:37 2016 +0300

    Change incorrect murano-agent bin file location

    During cloud-init related improvements murano-agent location was
    specified for the pip-style installation. This leads to unability
    to deploy the apps on the images with pre-installed murano-agent
    without network. This commit create a symlink to the pre-installed agent
    in place where pip usually installs packages.

    Change-Id: I8d90d33dc0a1c36ac4524f8f3b82223c23829126
    Closes-Bug: #1570962
    (cherry picked from commit 15df963544f4dc21492dd8641235081c85ce4025)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/369070

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/368488
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=ab4d479e9de4fbcd9b6e598c68d8c8c77daaa85f
Submitter: Jenkins
Branch: master

commit ab4d479e9de4fbcd9b6e598c68d8c8c77daaa85f
Author: Kirill Zaitsev <email address hidden>
Date: Mon Sep 12 00:02:57 2016 +0300

    Better detect and configure murano-agent pre-installed on image

    After I8d90d33dc0a1c36ac4524f8f3b82223c23829126 a bug has been
    introduced in setting agent's config: it was only set if there was no
    'muranoagent' binary in PATH. This patch fixes this behaviour.
    The patch also improves murano-agent detection, by setting PATH to a
    wider number of directories, when checking for murano-agent binary.
    It also improves support of different pre-built
    images by not restricting path to murano-agent binary to a specific path.
    Contains a bunch of comments with clarifications.

    Change-Id: Ie4c498b5546aabaab2070400452765c62cb561a3
    Closes-Bug: #1570962

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/369070
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=6a927bb9749b282cfe60197b52c98c6e302f912f
Submitter: Jenkins
Branch: stable/mitaka

commit 6a927bb9749b282cfe60197b52c98c6e302f912f
Author: Kirill Zaitsev <email address hidden>
Date: Mon Sep 12 00:02:57 2016 +0300

    Better detect and configure murano-agent pre-installed on image

    After I8d90d33dc0a1c36ac4524f8f3b82223c23829126 a bug has been
    introduced in setting agent's config: it was only set if there was no
    'muranoagent' binary in PATH. This patch fixes this behaviour.
    The patch also improves murano-agent detection, by setting PATH to a
    wider number of directories, when checking for murano-agent binary.
    It also improves support of different pre-built
    images by not restricting path to murano-agent binary to a specific path.
    Contains a bunch of comments with clarifications.

    Change-Id: Ie4c498b5546aabaab2070400452765c62cb561a3
    Closes-Bug: #1570962

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano 3.0.0.0rc1 release candidate.

[viswesuwara nathan (viswesn)]

The io.murano.zip from Ubuntu Xenial Mitaka is missing this fix. Thanks