Maintain visibility consistency for packages and images

[Olivier Lemasle]

When a package is imported using CLI or dashboard, Murano ensures that:
- packages dependencies are also imported,
- required images from images.lst are also imported.

But there is no visibility consistency: a package can be public and have private dependencies or require private images.

During the initial import of a package, package dependencies are imported with the same visibility as the main package.
https://bugs.launchpad.net/murano/+bug/1507139 addresses the same thing for required glance images.

But if a package is imported as a private package and is then made public:
* the required glance images will not become public
* the required packages will not become public.

This causes some bad user experience for a tenant having access to a package but not to its dependencies.

Murano (or Glance ?) should maintain the consistency to make sure each package has its dependencies with at least the same level of visibility.

[Ekaterina Chernova (efedorova)]

Hi!

Let;s discuss it at #murano or in ML.

We really need to think, should we support it now or just check ob Glance back end and fix it there if needed

[Valerii Kovalchuk (vakovalchuk)]

I guess the same problem occurs when the user deletes one of the dependencies and then tries to deploy the package

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/305677

[OpenStack Infra (hudson-openstack)]

Change abandoned by Valerii Kovalchuk (<email address hidden>) on branch: master
Review: https://review.openstack.org/305677
Reason: I agree that this patch is not maintain consistency properly. The solution must be more clean and done not in dashboard

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/310177

[OpenStack Infra (hudson-openstack)]

Change abandoned by Valerii Kovalchuk (<email address hidden>) on branch: master
Review: https://review.openstack.org/310177
Reason: I agree that this solution is not so effective and pretty. It was just try to satisfy the request for visibility consistency with the available means. Let's create more elegant plan.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Valerii Kovalchuk (<email address hidden>) on branch: master
Review: https://review.openstack.org/310251

[Valerii Kovalchuk (vakovalchuk)]

Now we have a blueprint to address this issue along with some other similar cases. https://blueprints.launchpad.net/murano/+spec/handle-package-requirements-consistency
Stay tuned there.