Double-clicking on the timestamps causes a crash

[Vadim Peretokin]

Double-clicking around on the timestamps causes a crash. See stacktrace:

0 TTextEdit::highlight TTextEdit.cpp 948 0x671317
1 TTextEdit::mousePressEvent TTextEdit.cpp 1334 0x672d77
2 QWidget::event qwidget.cpp 7942 0x7ffff649ac12
3 QApplicationPrivate::notify_helper qapplication.cpp 3486 0x7ffff645fc8c
4 QApplication::notify qapplication.cpp 3020 0x7ffff6465b61
5 QCoreApplication::notifyInternal qcoreapplication.cpp 881 0x7ffff5555c2d
6 sendSpontaneousEvent qcoreapplication.h 235 0x7ffff64639e1
7 QApplicationPrivate::sendMouseEvent qapplication.cpp 2507 0x7ffff64639e1
8 QWidgetWindow::handleMouseEvent qwidgetwindow.cpp 491 0x7ffff64b7bbf
9 QWidgetWindow::event qwidgetwindow.cpp 173 0x7ffff64b99bb
10 QApplicationPrivate::notify_helper qapplication.cpp 3486 0x7ffff645fc8c
11 QApplication::notify qapplication.cpp 3236 0x7ffff6464e56
12 QCoreApplication::notifyInternal qcoreapplication.cpp 881 0x7ffff5555c2d
13 sendSpontaneousEvent qcoreapplication.h 235 0x7ffff5a7525c
14 QGuiApplicationPrivate::processMouseEvent qguiapplication.cpp 1598 0x7ffff5a7525c
15 QGuiApplicationPrivate::processWindowSystemEvent qguiapplication.cpp 1409 0x7ffff5a76925
16 QWindowSystemInterface::sendWindowSystemEvents qwindowsysteminterface.cpp 575 0x7ffff5a5f858
17 userEventSourceDispatch qeventdispatcher_glib.cpp 78 0x7fffeb0f45b0
18 g_main_context_dispatch /lib/x86_64-linux-gnu/libglib-2.0.so.0 0x7ffff3859e04
19 ?? /lib/x86_64-linux-gnu/libglib-2.0.so.0 0x7ffff385a048
20 g_main_context_iteration /lib/x86_64-linux-gnu/libglib-2.0.so.0 0x7ffff385a0ec
... <More>

Originally reported at http://forums.mudlet.org/viewtopic.php?f=5&t=4684&sid=f66abbdb3247c7065528bbea688fe681&p=22264#p22264.

[Stephen Lyons (slysven)]

Is this a duplicate of https://bugs.launchpad.net/mudlet/+bug/1329948 ?

[Vadim Peretokin (vperetokin)]

Nah, that one is in a different function. Just similar symptoms.

[Stephen Lyons (slysven)]

Actually it is closely related. Turns out that the logic for taking 13 off of the x value to account for the un-selectable characters that are taken by the timestamp is flawed. The boolean that controls this - controlled by the timestamp control button only relates to the main console. However both the separate debug console and the errors window in the trigger editor have time stamps turned on ALL THE TIME so if the user does NOT have timestamps enabled, clicks in those windows will Seg. Fault (from using negative indexes on the TBuffer QList structures) - but if timestamps are on - the problem does not manifest.

It should be easy to logic OR the timestamp control I just referred to with the mIsDebugConsole to take care of the problem for the separate debug window, but I haven't yet determined how to detect if the TTextEdit instance is attached to the trigger editor's "errors" widget.

As this causes terminal Seg. Faults in the current beta I feel I must raise this to critical - but if someone with a better understanding of the TConsole/TTextEdit infrastructure can find out the way to detect the "errors" window we should be able to fix it quickly.

[Chris (chrismudlet)]

https://github.com/Mudlet/Mudlet/pull/243