rightclicking the left aligned timestamp "frame" crashes the client

Bug #1329948 reported by Fenwryches on 2014-06-13
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mudlet
Fix Released
Critical
Chris

Bug Description

Rightclicking on the timestamp "frame" causes the client to crash on win7 x32/64 and Ubuntu

Changed in mudlet:
status: New → Confirmed
Stephen Lyons (slysven) wrote :

Got it! In TTextEdit::mousePressEvent() when the timestamps are enabled the normal lines of text are offset to the right by 13 spaces (so the time stamps can go at the start of the line) this means the character x-coordinates used to manipulate text selections in the console have to have 13 added to them to refer to the correct text - but if the mouse is pressed in the time stamp area the coordinate will be less than zero which causes a seg. fault (the time stamp bit of the the text lines is NOT selectable).

The code for the left mouse button press correctly limits the x coordinate to not less than zero but the boundary value checks have not been repeated for the right mouse button press code.

The attached commit is for the current Source Forge Master but should apply to pretty much any recent version. Unfortunately I got my local master branch out of step with my public one on GitHub and until I can get them synced without losing other stuff locally I'm not sure I can push this commit out to my public repository directly.

Changed in mudlet:
importance: Undecided → Critical
Stephen Lyons (slysven) on 2014-06-19
Changed in mudlet:
assignee: nobody → Chris (chrismudlet)
Stephen Lyons (slysven) wrote :

Chris

Sorry if I've dropped it onto to you a bit abruptly but can you get this two line patch up into the current SF release?

Changed in mudlet:
status: Confirmed → Fix Committed
status: Fix Committed → Confirmed
Ahmed Charles (ahmedcharles) wrote :
Changed in mudlet:
milestone: none → 3.0
status: Confirmed → Fix Committed
Changed in mudlet:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers