Comment 7 for bug 1559949

Revision history for this message
Denis Meltsaykin (dmeltsaykin) wrote :

According to [0][1], OCF_NOT_RUNNING has no Recovery Type attached. So I'm wondering why we're using this return code at all? I'm not very confident in pacemaker's stuff, but I saw dozens of sources where it's clearly stated that OCF_NOT_RUNNING is not intended to show a _failure_, for failures OCF_ERR_* should be used.
Moreover, it is said also, that using OCF_NOT_RUNNING outside of any monitor action is an error and should be avoided. But we're using this return code unconditionally everywhere. I'm sure we should rethink return codes.

[0]: http://clusterlabs.org/doc/en-US/Pacemaker/1.1-pcs/html/Pacemaker_Explained/s-ocf-return-codes.html
[1]: http://clusterlabs.org/doc/en-US/Pacemaker/1.1-pcs/html/Pacemaker_Explained/_how_are_ocf_return_codes_interpreted.html