Comment 2 for bug 1806262
Revision history for this message
| Alejandro Perez (alejandro-perez-mendez) wrote | #2 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Hi Sam,
Your code looks good to me. I've found only a couple of minor issues that I detail below:
* The code does not build in CentOS 6 due to a problem with how old vala handles Hash tables. This one is fixed on my branch (see below).
* The code does not build in Ubuntu 14.04 because for some reason it fails to find definitions for "Collections" and "Item". This is not a problem because we can build with GKR for this target.
* The code does not build in Alpine v3.8 because they do not ship the .vapi file for libsecret-1. This also easily fixed as just including it from another distribution in our vapi folder does the trick.
I've pushed a new branch called libsecret_alex including two additional commits on top of yours:
* The first one fixes building in CentOS6 by switching to HashTable.lookup() rather than HashTable[]. It also removes a spurious printf line.
* The second one just make indentation more consistent, by using 4 spaces as for the rest of the code.