Comment 1 for bug 235382

Revision history for this message
ToddBrandt (todd-e-brandt) wrote :

Well, I wanted to keep the check simple because disk accesses can take a long time. My test platform has ~4000 images which is what I have to account for (I know many people with 1000 plus photos lying around, so I'm highballing the support scenerio to make sure that their user experience is good).

So right now, the first phase of the background load is to just read one or two directory's file tables and to create a list based on name. That means that even if there's 4000 images, the dialog is populated in well under a second.

If I do what you're suggesting, the initial load time before displaying the image name list will be anywhere from 1 to 5 seconds (depending on what power state ppm has the system in). That's because instead of reading in two tiny inodes, the applet now has to open 4000 file descriptors and pull in a kilobyte or so of data from each of the files. So that's the negative aspect of what you're proposing.

Also, since the background applet doesn't support the use of file searches or manual additions of directories, it's reasonable to assume that any directory that's tagged in gconf for the applet to traverse is going to be designated for image files only. So adding this check is likely going to be a redundant feature.

So the fact that it's likely redundant, combined with the fact that it will certainly add overhead, make me have to say no to this feature request. Interesting catch though.