Comment 19 for bug 981210

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Fist of all: thank you all testers.

For me, we have now already enough information to decide.

On most systems drawing QPixamp and QImage takes approximately the same time.
Then we have at least on system , where drawing QPixamp is buggy and some systems where QPixamp takes longer.

All test systems have run the test application and I have made test results from within the original Mixxx code that are verifying the results.

I do not expect any surprise from further investigations.

So for me, it should be save to change drawPixamp calls to draw Image. This will:
* Fix the bug
* Saves some CPU Time on some systems
* does not take significant more CPU time on other systems
* gains drawing on an optimized for IO QImage for all off screen renderer

Do you agree?
Then I would prepare an optimized patch.