The patch looks good to me -- here are my comments:
1) It's fine to keep the emit() for the hash progress where it was previously. I think even though it's a little bit of a fib it's better to have the progress dialog constantly updating so you don't think it's slow / hung.
2) The two methods updateDirectoryStatus and markTracksInDirectoryAsVerified were both created specifically for this part of the scanner and aren't used anywhere else. It would be even faster if you updated these two methods so that they take the whole list of directories and just issue one big update query instead of doing 1 query for each directory.
The patch looks good to me -- here are my comments:
1) It's fine to keep the emit() for the hash progress where it was previously. I think even though it's a little bit of a fib it's better to have the progress dialog constantly updating so you don't think it's slow / hung.
2) The two methods updateDirectory Status and markTracksInDir ectoryAsVerifie d were both created specifically for this part of the scanner and aren't used anywhere else. It would be even faster if you updated these two methods so that they take the whole list of directories and just issue one big update query instead of doing 1 query for each directory.