Hey mutil,
Short and sweet :). Looks good.
Is there a reason why you do:
QUrl url = QUrl::fromLocalFile(trackModel->getTrackLocation(index)); if (!url.isValid()) { ... }
if (url.scheme() != "file") continue;
QString path = url.toLocalFile();
instead of just:
QString path = trackModel->getTrackLocation(index);
I figure you just copy/pasted from other parts of wtracktableview.cpp that first created a QUrl but I think it's fine to just do the latter. Just asking in case you found some case where it was necessary to do that.
Hey mutil,
Short and sweet :). Looks good.
Is there a reason why you do:
QUrl url = QUrl::fromLocal File(trackModel ->getTrackLocat ion(index) );
if (!url.isValid()) {
...
}
if (url.scheme() != "file")
continue;
QString path = url.toLocalFile();
instead of just:
QString path = trackModel- >getTrackLocati on(index) ;
I figure you just copy/pasted from other parts of wtracktableview.cpp that first created a QUrl but I think it's fine to just do the latter. Just asking in case you found some case where it was necessary to do that.