Comment 3 for bug 941379

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hey mutil,

Short and sweet :). Looks good.

Is there a reason why you do:

QUrl url = QUrl::fromLocalFile(trackModel->getTrackLocation(index));
if (!url.isValid()) {
...
}

if (url.scheme() != "file")
  continue;

QString path = url.toLocalFile();

instead of just:

QString path = trackModel->getTrackLocation(index);

I figure you just copy/pasted from other parts of wtracktableview.cpp that first created a QUrl but I think it's fine to just do the latter. Just asking in case you found some case where it was necessary to do that.