Mixxx

  1. Bug #938648
  2. Comment #2

Comment 2 for bug 938648

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hey Daniel,

I see you use toLocal8Bit() as the argument to sf_open. In src/soundsourcesndfile.cpp you'll see that on Windows we use toLocal8Bit() but on all others we use toUtf8().

Does toUtf8() work as well? Even if it does, I'd prefer we duplicate the logic in src/soundsourcesndfile.cpp unless you know of a reason not to.

Also, we should probably get people to test this on Windows, Mac and Linux before committing.