support pushbutton EQ kill switches instead of toggle

Bug #918470 reported by M. Wiśniewski on 2012-01-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Wishlist
Daniel Schürmann

Bug Description

Right now killswitches can be only toggled, for some usages (future multitouch maybe) it could be nice to enable them only while pressed (for example - right click).

RJ Skerry-Ryan (rryan) on 2012-01-19
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
tags: removed: improvements
summary: - change killswitch behaviour
+ support pushbutton EQ kill switches instead of toggle
jus (jus) wrote :

This is already possible with modifications to the skin definition file.
 Although one would have to decide between active while pressed/ toggle behavior.

jus (jus) wrote :

Update:
If the "Power window" behavior ( see lp:876139 )is implemented in 1.11 it will work like this:
Short push: enable EQ kill
Second short push: disable EQ kill
Long push t > 0,5 s: EQ kill while button down

TODO: Update skins tooltips to reflect the new functionality if patch get merged.

Changed in mixxx:
milestone: none → 1.11.0
status: Confirmed → In Progress
assignee: nobody → Daniel Schürmann (daschuer)
Daniel Schürmann (daschuer) wrote :

The attached patch changes all EQ kill switches in all skins to power window style.
The patch of bug #876139 is required.

RJ Skerry-Ryan (rryan) wrote :

Note that Bug #876139 is now committed, though the <PowerWindowStyle> block is not necessary.

RJ Skerry-Ryan (rryan) wrote :

Also, this patch doesn't change the kill-switches to be power-window style in src/engine/enginefilterblock.cpp.

jus (jus) wrote :

RJ Could you please explain your comment from #5?
When i apply Daniels patch to the skins (see example), the kill buttons do not have the desired behavior, they work as toggle just as before.
Generally the Power window behavior does work, as i have successfully adapted the patch to the talkover button.

Example (just as in the patch)
<PushButton>
 <Tooltip></Tooltip>
 <Style></Style>
 <NumberStates>2</NumberStates>
 <State>
  <Number>0</Number>
  <Pressed>btn_kill_over.png</Pressed>
  <Unpressed>btn_kill.png</Unpressed>
 </State>
 <State>
  <Number>1</Number>
  <Pressed>btn_kill_over.png</Pressed>
  <Unpressed>btn_kill_over.png</Unpressed>
 </State>
 <Pos>73,159</Pos>
 <Connection>
  <ConfigKey>[Channel1],filterHighKill</ConfigKey>
  <EmitOnPressAndRelease>true</EmitOnPressAndRelease>
  <ButtonState>LeftButton</ButtonState>
 </Connection>
</PushButton>

RJ Skerry-Ryan (rryan) wrote :

Yup, that was what my comment was about. These changes also need to be made:

=== modified file 'mixxx/src/engine/enginefilterblock.cpp'
--- mixxx/src/engine/enginefilterblock.cpp 2012-05-01 05:59:37 +0000
+++ mixxx/src/engine/enginefilterblock.cpp 2012-05-01 14:15:50 +0000
@@ -71,15 +71,15 @@

     filterpotLow = new ControlLogpotmeter(ConfigKey(group, "filterLow"), 4.);
     filterKillLow = new ControlPushButton(ConfigKey(group, "filterLowKill"));
- filterKillLow->setButtonMode(ControlPushButton::TOGGLE);
+ filterKillLow->setButtonMode(ControlPushButton::POWERWINDOW);

     filterpotMid = new ControlLogpotmeter(ConfigKey(group, "filterMid"), 4.);
     filterKillMid = new ControlPushButton(ConfigKey(group, "filterMidKill"));
- filterKillMid->setButtonMode(ControlPushButton::TOGGLE);
+ filterKillMid->setButtonMode(ControlPushButton::POWERWINDOW);

     filterpotHigh = new ControlLogpotmeter(ConfigKey(group, "filterHigh"), 4.);
     filterKillHigh = new ControlPushButton(ConfigKey(group, "filterHighKill"));
- filterKillHigh->setButtonMode(ControlPushButton::TOGGLE);
+ filterKillHigh->setButtonMode(ControlPushButton::POWERWINDOW);

RJ Skerry-Ryan (rryan) wrote :

I went ahead and added that patch I just posted in #7 so the skin updates from Daniel's original patch in this bug report should work now.

jus (jus) on 2012-05-01
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan) on 2013-05-09
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers