Comment 3 for bug 913031

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Here are my thoughts:

1) VAMP support is coming in 1.11 which is a huge step forward for getting beatgrids right automatically. Hopefully this will lessen the urgency of having a rounding feature.

2) Mixxx doesn't have any proper way to indicate the source of analysis data. We don't have a way to differentiate between a BPM value that is
* Read from an ID3 tag
* Typed by a user
* Tapped by a user
* Detected by SoundTouch
* Rounded by this code

Because of #2, I am very wary of any preference option that modifies database entries permanently. Once we have a more general way for a track to have multiple "Analyses" that the user can pick as their default (e.g. you can choose to ignore the Mixxx generated analysis and activate the beatgrid we got from Traktor via the track-info dialog) then I would be happy with making this generate an alternate analysis that is the rounded form of an existing one.

Having a preference option to round on track-load is nice if you assume every single detected BPM is wrong and should be a whole number. I think this will become less useful in 1.11 since our BPM detection will be a lot better. The VAMP branch is already getting VERY positive reviews by people who are using it and it is within a small margin of error from Traktor most of the time.

It would also be nice to have a right-click context menu or maybe an option on the track info dialog that allows the user to manually choose to round the BPM of a track. It would essentially be a quick helper to save the time of typing out the rounded BPM by hand. That would be an easy project for a new contributor that we could leave around in the wishlist.