Mixxx

  1. Bug #886624
  2. Comment #3

Comment 3 for bug 886624

Revision history for this message
ronso0 (ronso0) wrote :

I think this can be resolved rather "easily", no need to violate HIG:

1. in the preferences main dialog, intercept the
  QDialogButtonBox::accepted signal and accept() the dialog only if
  okayToclose of each pref page is true (default)
2. in DlgPrefSound::slotApply, set okayToClose to true only if
  SoundDeviceError is SOUNDDEVICE_ERROR_OK

Does that makes sense?

https://github.com/mixxxdj/mixxx/blob/828a189b045050ca6ad5aa053e528e92ce0b8653/src/preferences/dialog/dlgpreferences.cpp#L408-L442