Comment 6 for bug 854082

Revision history for this message
shanxS (shanx-shashank) wrote : Re: Lowband-EQ is creaking

Hey RJ!

> Are you able to reproduce and confirm that the smooth-fading fixes it?
Yes, on my Linux box (core i3, 4GB) I can reproduce this issue.

I can see the point you are trying to make with latency and ramp-ing.
This patch is latency based.

Here is the idea:
1. Latency effects the size of audio buffer engine needs to process between each callback of PortAudio. Latency is inversely proportional to buffer size, its simple relation between sampling freq. and time

2. Creaking is because the jumps in 'gain' are of high magnitude

3. If, the jump is 'ramped' to samples (opposed to a frame, like in my prev. patch) Then the ramping will be finished in 1 audio frame itself.

Potential problem:
I cant run Mixxx on latencies below 11 ms, so I couldnt test on lower latencies.

Coming to the point of implementing ramp-ing in as a feature of ControlObject:
I think, ramp- ing should be more a feature of functions in SampleUtil class.
OR a part of ::process() functions which do some kind of DSP.
That is because (maybe in future) someone might need exact value
of the CO (and not the ramp-ed one). This is just a thought.