Comment 19 for bug 801700

Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 801700] Re: high memory consumption when indexing library

One other thing to point out -- the original code puts the adding of tracks
in a transaction via ScopedTransaction. Now that the adding happens over
many function calls you will need to either manually start and commit the
transaction or possibly pull the ScopedTransaction into the library scanner
and out of the DAO. (I much prefer ScopedTransaction to manually managing
the transaction because it eliminates the possibility that you've forgotten
to commit or rollback and leave the database in a bad state).

On Thu, Jun 28, 2012 at 12:09 PM, Max Linke <email address hidden>wrote:

> Shame on me, I was wrong with the mutexLocker. I have to scope it in
> TrackDAO::getTrack() so that mixxx won't freeze.
>
> This patches uses setValue,which is indead nicer) and all functions now
> use getTrackForColumn with the reference call, I probably made an error
> earlier.
>
> ** Patch added: "library_scanner_track_dao_v10.patch"
>
> https://bugs.launchpad.net/mixxx/+bug/801700/+attachment/3206846/+files/library_scanner_track_dao_v10.patch
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/801700
>
> Title:
> high memory consumption when indexing library
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/801700/+subscriptions
>