Comment 15 for bug 774808

Nice one Rowen.
Had the chance to test your branch and would like to give some feedback.

* The fact that samplers now jumps back to start when reaching end of sample is a good touch, and i can see it being the standard on the regular decks as well.

* The multi-state button to indicate the samplers playback mode is fine. With the sampler decks there is always little space and we use multi-state buttons already in other places. Also, dont waste time on the buttons look, we'll take care of that later.

* The existing Repat control seems ok for now, but works only if we play a sample to it's end. If we'd further extend the sampler functionality, like starting from an Cue or Loop-In point and stopping at Loop-Out, then we'll need a new state for the play_mode control. Another thing it would be come handy is when we start playback in a predefined loop-size (loops and loop resize controls work in samplers too).

* Integrating the new "play_mode" control into src/skin/tooltips.cpp and /src/controllers/dlgcontrollerlearning.cpp would be beneficial. This allows to display the buttons tooltips in the skins and to assign buttons on external MIDI devices to the control.

* There is a flaw when a sample is playing and and you change the playback mode in between: Set playback mode to [ 2 ] ans start playing. While playing, set playback mode to [ 3 ] or [ 4 ] and click the play button again. The play buttons changes to it's inactive state even if the sample is still playing. Then, if the sample reaches the end, it does not jump back to start.

Good work so far, thanks