Comment 23 for bug 742388

Hi RJ,

the problem might be at https://github.com/mixxxdj/mixxx/blob/master/src/widget/wstatuslight.cpp#L119
We call update() uncontrolled.
I cannot see why this is not required in wvumeter. But this is updated more often in normal conditions, so it should share a common solution.

--

By the way, it is the right time to get rid of:
clipped = SampleUtil::copyClampBuffer(kfMaxAmp, -kfMaxAmp,
                                          pOutput, pIn, iBufferSize);

IMHO it is just a bad idea to just clamp the buffer. Can't we just allow samples > 1? Everything that will happen due to it in the following signal processing can't be worth. I am sure it is camped before it is copied to a 24 bit DAC.

If we allow Samples > 1.0 inside Mixxx we just allow a grater dynamic range. The user only have to be sure, by using the Master volume that the output is not clipped. That's all.

The peakIndicator can be calulates in sumAbsPerChannel inside EngineVUMeter.

Oh sorry for be off topic, will file a new bug.